looks good. did you find the commit where the regression was introduced?

No no, should i look into it?

looks good. did you find the commit where the regression was introduced?

No no, should i look into it?

yes please -- i was going to include it when drafting the commit message

looks good. did you find the commit where the regression was introduced?

No no, should i look into it?

yes please -- i was going to include it when drafting the commit message

I think it was always there.

6b8b7f6c558cff79f5b552ed8a13df296b469a58 is the first bad commit
commit 6b8b7f6c558cff79f5b552ed8a13df296b469a58
Author: Ben Hauser <[email protected]>
Date:   Fri Aug 21 17:15:06 2020 +0300

    refactor: allow access to vyper-json via vyper-compile

 vyper/cli/vyper_compile.py | 16 +++++++++++++++-
 1 file changed, 15 insertions(+), 1 deletion(-)

when run against

{
 "abi": [
   {
     "name": "validate",
     "inputs": [
       { "name": "creator", "type": "address" },
       { "name": "token", "type": "address" },
       { "name": "amount_per_second", "type": "uint256" },
       { "name": "reason", "type": "bytes" }
     ],
     "outputs": [{ "name": "max_stream_life", "type": "uint256" }]
   }
 ]
}

The error was the same across all commits.

something is weird, because we theoretically used to have code to handle this, e.g.

something is weird, because we theoretically used to have code to handle this, e.g.

vyper/vyper/cli/vyper_compile.py

Lines 264 to 268 in 9136169

	# ABI JSON file (either `List[ABI]` or `{"abi": List[ABI]}`)
	elif isinstance(contents, list) or (
	"abi" in contents and isinstance(contents["abi"], list)
	):
	interfaces[file_path][interface_name] = {"type": "json", "code": contents}

i didn't look deeply into the code, but in this link we don't flatten the "abi" dict into the list (which is what we do in this fix)

something is weird, because we theoretically used to have code to handle this, e.g.

vyper/vyper/cli/vyper_compile.py

Lines 264 to 268 in 9136169

	# ABI JSON file (either `List[ABI]` or `{"abi": List[ABI]}`)
	elif isinstance(contents, list) or (
	"abi" in contents and isinstance(contents["abi"], list)
	):
	interfaces[file_path][interface_name] = {"type": "json", "code": contents}

i didn't look deeply into the code, but in this link we don't flatten the "abi" dict into the list (which is what we do in this fix)

so why is this considered a regression 🤔 paging @fubuloubu

The regression might be that it didn't try and check anything was implemented because it was empty?

This fix seems good regardless

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 46.08%. Comparing base (4845fd4) to head (8a8f35b).

❗ There is a different number of reports uploaded between BASE (4845fd4) and HEAD (8a8f35b). Click for more details.

HEAD has 139 uploads less than BASE

Flag	BASE (4845fd4)	HEAD (8a8f35b)
	140	1

@@             Coverage Diff             @@
##           master    #4279       +/-   ##
===========================================
- Coverage   91.36%   46.08%   -45.29%     
===========================================
  Files         110      110               
  Lines       15810    15812        +2     
  Branches     2678     2679        +1     
===========================================
- Hits        14445     7287     -7158     
- Misses        931     7974     +7043     
- Partials      434      551      +117     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.