Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.12%. Comparing base (c75a2da) to head (de3bdff).
Report is 95 commits behind head on master.

@@           Coverage Diff           @@
##           master    #4275   +/-   ##
=======================================
  Coverage   92.12%   92.12%           
=======================================
  Files         119      119           
  Lines       16967    16969    +2     
  Branches     2872     2872           
=======================================
+ Hits        15631    15633    +2     
  Misses        918      918           
  Partials      418      418           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

there's something interesting going on with examples like

log Transfer(msg.sender, msg.sender, 1)  # 1 is only one character long

i guess mark_tokens() marks the wrong start+end position for the ast node.

i'd say the mark_tokens issue is out of scope -- it should be addressed in #4364

let's please add some tests

it seems that not all nodes have the source assigned?

event Foo:
       a: uint256

@external
def foo(a: uint256):
    log Foo(a)

UserWarning: Instantiating events with positional arguments is deprecated as of v0.4.1 and will be disallowed in a future release. Use kwargs instead e.g.:

Foo(a=)

  contract "tests/custom/test.vy:6", function "foo", line 6:8 
       5 def foo(a: uint256):
  ---> 6     log Foo(a)
  ---------------^
       7

  vyper_warn(msg, node)

notice Foo(a=)

it seems that not all nodes have the source assigned?

event Foo:
       a: uint256

@external
def foo(a: uint256):
    log Foo(a)

UserWarning: Instantiating events with positional arguments is deprecated as of v0.4.1 and will be disallowed in a future release. Use kwargs instead e.g.:

Foo(a=)

  contract "tests/custom/test.vy:6", function "foo", line 6:8 
       5 def foo(a: uint256):
  ---> 6     log Foo(a)
  ---------------^
       7

  vyper_warn(msg, node)

notice Foo(a=)

Yea that's what I mentioned here
#4275 (comment)

Yea that's what I mentioned here #4275 (comment)

oh, that wasn't clear to me from the comment, but i didn't run the attached code

in that case can we add 1 xfail test please?

note: waiting on #4364. we should update the logs in the examples directory in this PR as well.