feat[venom]: add load elimination pass#4265
feat[venom]: add load elimination pass#4265charles-cooper merged 23 commits intovyperlang:masterfrom
Conversation
charles-cooper
force-pushed
the
feat/load-elimination
branch
from
3c4f250 to
6923199
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4265 +/- ##
==========================================
- Coverage 91.74% 89.99% -1.76%
==========================================
Files 118 119 +1
Lines 16581 16615 +34
Branches 2789 2796 +7
==========================================
- Hits 15213 14953 -260
- Misses 936 1172 +236
- Partials 432 490 +58 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Fix lint Co-authored-by: Harry Kalogirou <[email protected]>
|
|
||
| if inst.opcode == "mstore": | ||
| # mstore [val, ptr] | ||
| memory = (inst.operands[1], inst.operands[0]) |
There was a problem hiding this comment.
Could we just switch it so the order in which the value and ptr is store we cannot always switch them (just to make it simple to reason about it)
There was a problem hiding this comment.
i think the reason i wrote it like that is to kind of hint at a future implementation with lattice (mapping locations to values), it will look like
val, ptr = inst.operands
memory[ptr] = val
There was a problem hiding this comment.
i rewrote it a bit so that we don't have to look at the reversal of the indexes
6faffba
--------- Co-authored-by: HodanPlodky <[email protected]>
charles-cooper
changed the title
3 participants
What I did
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture