fix[lang]: fix == and != bytesM folding#4254
Merged
charles-cooper merged 3 commits intovyperlang:masterfrom Sep 26, 2024
Merged
fix[lang]: fix == and != bytesM folding#4254charles-cooper merged 3 commits intovyperlang:masterfrom
== and != bytesM folding#4254charles-cooper merged 3 commits intovyperlang:masterfrom
Conversation
trocher
changed the title
== and != bytes folding
Co-authored-by: Charles Cooper <[email protected]>
charles-cooper
approved these changes
Sep 26, 2024
charles-cooper
changed the title
== and != bytes folding== and != bytesM folding
charles-cooper
added a commit
to charles-cooper/vyper
that referenced
this pull request
Oct 5, 2024
`bytesM` literals are not case-sensitive (they represent the same value no matter if the literal is lower- or upper-case), but the folding operation was case sensitive. --------- Co-authored-by: Charles Cooper <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Fix
[bytesN] [==|!=] [bytesN]to be folded as the operation was computed on python strings and not integer values.How I did it
Compare lowercase strings instead of strings to be case-insensitive.
How to verify it
The test is explicit.
Before this, the following would hold.
Commit message
Description for the changelog
Cute Animal Picture