feat[venom]: add common subexpression elimination#4241
Merged
charles-cooper merged 200 commits intovyperlang:masterfrom Apr 25, 2025
Merged
feat[venom]: add common subexpression elimination#4241charles-cooper merged 200 commits intovyperlang:masterfrom
charles-cooper merged 200 commits intovyperlang:masterfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| class _Expression: | ||
| first_inst : IRInstruction | ||
| opcode: str | ||
| operands : list[IROperand] |
Member
There was a problem hiding this comment.
looks like this can be IROperand | _Expression
Co-authored-by: Charles Cooper <[email protected]>
…ar fix Co-authored-by: Charles Cooper <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4241 +/- ##
==========================================
+ Coverage 92.42% 92.44% +0.01%
==========================================
Files 125 127 +2
Lines 18017 18308 +291
Branches 3110 3174 +64
==========================================
+ Hits 16653 16925 +272
- Misses 931 946 +15
- Partials 433 437 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
charles-cooper
approved these changes
Apr 22, 2025
Member
charles-cooper
left a comment
charles-cooper
left a comment
There was a problem hiding this comment.
awesome! please write up a commit message and ping me when you have given a final look over and think it's ready to merge
we will explore performance improvements in a followup PR Revert "comment" This reverts commit 326f317. Revert "add a comment" This reverts commit 2f46fab. Revert "lru_cache flag operations" This reverts commit 186d373. Revert "copy is shallow" This reverts commit c5b8621. Revert "less copies" This reverts commit 90165e0.
charles-cooper
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Created common subexpression elimination pass
How I did it
Created available expression analysis and common subexpressions elimination pass. The available expression analysis is done with consideration to effects which heavy inspired by multidimensional fencing.
How to verify it
Created tests
Commit message
Cute Animal Picture