fix[ux]: fix relpath compiler panic on windows#4228
fix[ux]: fix relpath compiler panic on windows#4228charles-cooper merged 2 commits intovyperlang:masterfrom
Conversation
fix a bug where relpath raises an exception on window, when the source path and the destination path are on different drives.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4228 +/- ##
==========================================
- Coverage 91.35% 90.36% -0.99%
==========================================
Files 109 109
Lines 15637 15641 +4
Branches 3443 3443
==========================================
- Hits 14285 14134 -151
- Misses 920 1043 +123
- Partials 432 464 +32 ☔ View full report in Codecov by Sentry. |
| try: | ||
| return os.path.relpath(path) | ||
| except ValueError: | ||
| # on Windows, if path and curdir are on different drives, an exception |
There was a problem hiding this comment.
Would the path be an absolute path in this scenario?
There was a problem hiding this comment.
yeah, I'm not sure about this
the reported issue targeted builtins, which use __path__, which is absolute, and thus, the approach should work. although safe_relpath which returns an abs path is a bit weird
but it might be that a relative path is in search paths, right? And that path could reference a different drive causing the exception. but in that case it's likely a user error?
There was a problem hiding this comment.
relpath is also used even if a different search path is used to resolve a path, for instance for error reporting it is used to report relative to the user's current directory. but on windows if you can't construct the relpath, you can't construct the relpath
3 participants
fix a bug where relpath raises an exception on window, when the source path and the destination path are on different drives.
What I did
fix #4227
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture