feat[lang]: add `raw_create()` builtin by charles-cooper · Pull Request #4204 · vyperlang/vyper

charles-cooper · 2024-08-08T14:01:08Z

What I did

implement #3710

How I did it

How to verify it

Commit message

this commit adds a `raw_create()` builtin, which executes the
corresponding `CREATE` or `CREATE2` opcode on the provided bytes, as
well as ABI-encoding the provided arguments and appending them to the
provided initcode.

Description for the changelog

Cute Animal Picture

cyberthirst · 2024-08-12T08:32:00Z

let's also update the docs please

cyberthirst · 2024-08-13T07:25:35Z

vyper/builtins/functions.py

+            ret.append(copy_bytes(buf, bytes_data_ptr(initcode), bytecode_len, maxlen))
+
+            argbuf = add_ofst(buf, bytecode_len)
+            argslen = abi_encode(argbuf, to_encode, context, bufsz=bufsz, returns_len=True)


this reminds of something: #4202

cyberthirst · 2024-08-13T11:22:10Z

vyper/builtins/functions.py

+
+            argbuf = add_ofst(buf, bytecode_len)
+            argslen = abi_encode(argbuf, to_encode, context, bufsz=bufsz, returns_len=True)
+            total_len = add_ofst(argbuf, argslen)


i think this is wrong - isn't the length now absolute wrt 0?
shouldn't it be smth like total_len = ["sub", add_ofst(argbuf, argslen), buf]

add raw_create tests

cyberthirst · 2024-08-28T09:35:34Z

vyper/builtins/functions.py

+            bytecode_len = get_bytearray_length(initcode)
+
+            maxlen = initcode.typ.maxlen
+            ret.append(copy_bytes(buf, bytes_data_ptr(initcode), bytecode_len, maxlen))


it shouldn't be problematic that copy_bytes might pad to ceil32, right?

it might copy some dirty data, but if arguments are provided, those should overwrite it

if no args are provided, we still operate with bytecode_len which will lead to ignoring the dirty data

cyberthirst · 2024-08-28T11:20:54Z

can we please add tests for the rest of the kws?

add tests for raw_create

codecov · 2024-09-16T20:10:36Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.35%. Comparing base (18d0787) to head (48e2039).
Report is 88 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4204      +/-   ##
==========================================
+ Coverage   92.34%   92.35%   +0.01%     
==========================================
  Files         123      123              
  Lines       17472    17499      +27     
  Branches     2949     2949              
==========================================
+ Hits        16135    16162      +27     
  Misses        933      933              
  Partials      404      404

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

pcaversaccio · 2024-10-14T22:03:07Z

Can we ship this PR?

pcaversaccio

I think this PR is a good opportunity to discuss the following:

How do you feel about extending the PR to include my issue here as well: #4147?
The built-in is great but to increase the overall devex, we need to bundle it with some type information feature for contracts: i.e. erc20.creation_code, erc20.runtime_code, erc20.interface_id. The creation_code information can be super useful here.

Add a test

cyberthirst · 2025-03-17T13:13:33Z

docs/built-in-functions.rst

+
+.. py:function:: raw_create(initcode: Bytes[...], *args, value: uint256 = 0, revert_on_failure: bool = True[, salt: bytes32]) -> address
+
+    Create a physical copy of the runtime code at ``target``. The code at ``target`` is byte-for-byte copied into a newly deployed contract.


is the target here with us?

7c6da48 and e10e3f5

add more raw_create tests

@external

### 🕓 Changelog Vyper has recently introduced the new `raw_create` built-in function via PR [#4204](vyperlang/vyper#4204), enabling direct contract creations using the EVM opcodes [`CREATE`](https://www.evm.codes/?fork=cancun#f0) and [`CREATE2`](https://www.evm.codes/?fork=cancun#f5). In response, this PR adds [`CREATE`](https://www.evm.codes/?fork=cancun#f0), [`CREATE2`](https://www.evm.codes/?fork=cancun#f5), and [`CREATE3`](ethereum/EIPs#3171 (i.e. without an initcode factor) utility functions to the corresponding module contracts in 🐍 snekmate. Please note that the current upper limit for the contract creation code is set to `8_192` bytes (\$2^{13}\$). ```vy from snekmate.utils import create as c1 from snekmate.utils import create2 as c2 from snekmate.utils import create3 as c3 @external @payable def deploy_create(init_code: Bytes[8_192]) -> address: return c1._deploy_create(init_code) @external @payable def deploy_create2(salt: bytes32, init_code: Bytes[8_192]) -> address: return c2._deploy_create2(salt, init_code) @external @payable def deploy_create3(salt: bytes32, init_code: Bytes[8_192]) -> address: return c3._deploy_create3(salt, init_code) ``` ### ⚠️ Breaking Changes To improve clarity and maintain consistent naming conventions, the following name changes are included in this PR: - `create_address.vy` → create.vy` - `_compute_address_rlp_self` → `_compute_create_address_self` - `_compute_address_rlp` → `_compute_create_address` - `_convert_keccak256_2_address` → `_convert_keccak256_to_address` - `create2_address.vy` → `create2.vy` - `_compute_address_self` → `_compute_create2_address_self` - `_compute_address` → `_compute_create2_address` These name changes are **not** backward-compatible and may require code updates in downstream projects. Furthermore, Solidity has released its latest version [`v0.8.30`](https://github.com/ethereum/solidity/releases/tag/v0.8.30). This PR updates the Solidity test files to align with this new version (we keep `evm_version = "cancun"`). --------- Signed-off-by: Pascal Marco Caversaccio <[email protected]>

@external

### 🕓 Changelog Vyper has recently introduced the new `raw_create` built-in function via PR [#4204](vyperlang/vyper#4204), enabling direct contract creations using the EVM opcodes [`CREATE`](https://www.evm.codes/?fork=cancun#f0) and [`CREATE2`](https://www.evm.codes/?fork=cancun#f5). In response, this PR adds [`CREATE`](https://www.evm.codes/?fork=cancun#f0), [`CREATE2`](https://www.evm.codes/?fork=cancun#f5), and [`CREATE3`](ethereum/EIPs#3171 (i.e. without an initcode factor) utility functions to the corresponding module contracts in 🐍 snekmate. Please note that the current upper limit for the contract creation code is set to `8_192` bytes (\$2^{13}\$). ```vy from snekmate.utils import create as c1 from snekmate.utils import create2 as c2 from snekmate.utils import create3 as c3 @external @payable def deploy_create(init_code: Bytes[8_192]) -> address: return c1._deploy_create(init_code) @external @payable def deploy_create2(salt: bytes32, init_code: Bytes[8_192]) -> address: return c2._deploy_create2(salt, init_code) @external @payable def deploy_create3(salt: bytes32, init_code: Bytes[8_192]) -> address: return c3._deploy_create3(salt, init_code) ``` ### ⚠️ Breaking Changes To improve clarity and maintain consistent naming conventions, the following name changes are included in this PR: - `create_address.vy` → create.vy` - `_compute_address_rlp_self` → `_compute_create_address_self` - `_compute_address_rlp` → `_compute_create_address` - `_convert_keccak256_2_address` → `_convert_keccak256_to_address` - `create2_address.vy` → `create2.vy` - `_compute_address_self` → `_compute_create2_address_self` - `_compute_address` → `_compute_create2_address` These name changes are **not** backward-compatible and may require code updates in downstream projects. Furthermore, Solidity has released its latest version [`v0.8.30`](https://github.com/ethereum/solidity/releases/tag/v0.8.30). This PR updates the Solidity test files to align with this new version (we keep `evm_version = "cancun"`). --------- Signed-off-by: Pascal Marco Caversaccio <[email protected]>

@external

### 🕓 Changelog Vyper has recently introduced the new `raw_create` built-in function via PR [#4204](vyperlang/vyper#4204), enabling direct contract creations using the EVM opcodes [`CREATE`](https://www.evm.codes/?fork=cancun#f0) and [`CREATE2`](https://www.evm.codes/?fork=cancun#f5). In response, this PR adds [`CREATE`](https://www.evm.codes/?fork=cancun#f0), [`CREATE2`](https://www.evm.codes/?fork=cancun#f5), and [`CREATE3`](ethereum/EIPs#3171 (i.e. without an initcode factor) utility functions to the corresponding module contracts in 🐍 snekmate. Please note that the current upper limit for the contract creation code is set to `8_192` bytes (\$2^{13}\$). ```vy from snekmate.utils import create as c1 from snekmate.utils import create2 as c2 from snekmate.utils import create3 as c3 @external @payable def deploy_create(init_code: Bytes[8_192]) -> address: return c1._deploy_create(init_code) @external @payable def deploy_create2(salt: bytes32, init_code: Bytes[8_192]) -> address: return c2._deploy_create2(salt, init_code) @external @payable def deploy_create3(salt: bytes32, init_code: Bytes[8_192]) -> address: return c3._deploy_create3(salt, init_code) ``` ### ⚠️ Breaking Changes To improve clarity and maintain consistent naming conventions, the following name changes are included in this PR: - `create_address.vy` → create.vy` - `_compute_address_rlp_self` → `_compute_create_address_self` - `_compute_address_rlp` → `_compute_create_address` - `_convert_keccak256_2_address` → `_convert_keccak256_to_address` - `create2_address.vy` → `create2.vy` - `_compute_address_self` → `_compute_create2_address_self` - `_compute_address` → `_compute_create2_address` These name changes are **not** backward-compatible and may require code updates in downstream projects. Furthermore, Solidity has released its latest version [`v0.8.30`](https://github.com/ethereum/solidity/releases/tag/v0.8.30). This PR updates the Solidity test files to align with this new version (we keep `evm_version = "cancun"`). --------- Signed-off-by: Pascal Marco Caversaccio <[email protected]>

feat: implement raw_create

af85a5c

charles-cooper marked this pull request as draft August 8, 2024 14:01

charles-cooper added this to the v0.4.1 milestone Aug 8, 2024

charles-cooper changed the title ~~feat: implement raw_create~~ feat[lang]: add raw_create() builtin Aug 8, 2024

add simple test

a4f2935

cyberthirst reviewed Aug 13, 2024

View reviewed changes

cyberthirst and others added 5 commits August 13, 2024 13:33

add tests for raw_create

dc3e377

Merge pull request #43 from cyberthirst/raw_create

2704208

add raw_create tests

fix buf bound bug

394b637

fix total_len

e7025ae

Merge branch 'master' into raw_create

f6caecc

charles-cooper marked this pull request as ready for review August 27, 2024 14:58

cyberthirst reviewed Aug 28, 2024

View reviewed changes

cyberthirst and others added 7 commits September 4, 2024 14:44

add tests for raw_create

2870bd9

merge value and revert tests

513de70

rename test

f77c64a

encode args within raw_create

961c406

simplify revert condition

26698e6

add comment

49ccb9b

Merge pull request #45 from cyberthirst/raw_create

8a07ccb

add tests for raw_create

fix lint

c25430a

Merge branch 'master' into raw_create

b6a6079

pcaversaccio reviewed Oct 20, 2024

View reviewed changes

pcaversaccio mentioned this pull request Oct 22, 2024

Support creation_code and runtime_code contract type information #4323

Open

add test

6fe48c9

trocher and others added 7 commits October 22, 2024 16:48

add xfail

1982adf

apply suggestion regarding dummy_bytes

96dc6a9

Merge pull request #47 from trocher/chore/raw_create_change_length_test

12c1944

Add a test

remove xfail

080b436

fix order of eval bug

af446b0

Merge branch 'master' into raw_create

eafd506

Merge branch 'master' into raw_create

1aa4e00

cyberthirst modified the milestones: v0.4.1, v0.4.2 Mar 10, 2025

charles-cooper added the release - must release blocker label Mar 17, 2025

charles-cooper added 2 commits March 17, 2025 12:22

Merge branch 'master' into raw_create

2479fde

add docs

4f7c6cb

cyberthirst reviewed Mar 17, 2025

View reviewed changes

charles-cooper and others added 5 commits March 17, 2025 14:26

docs: remove nonexistent target

e10e3f5

remove other target

7c6da48

ensure everything is in memory

6790978

add more raw_create tests

315c298

Merge pull request #63 from cyberthirst/fork/charles-cooper/raw_create

465aded

add more raw_create tests

cyberthirst approved these changes Mar 18, 2025

View reviewed changes

Merge branch 'master' into raw_create

48e2039

charles-cooper enabled auto-merge (squash) March 22, 2025 16:37

charles-cooper merged commit 61d259a into vyperlang:master Mar 22, 2025
159 checks passed

pcaversaccio mentioned this pull request May 12, 2025

💥 Add CREATE, CREATE2, and CREATE3 Deploy Functions pcaversaccio/snekmate#323

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat[lang]: add `raw_create()` builtin#4204

feat[lang]: add `raw_create()` builtin#4204
charles-cooper merged 32 commits intovyperlang:masterfrom
charles-cooper:raw_create

charles-cooper commented Aug 8, 2024 •

edited

Loading

Uh oh!

cyberthirst commented Aug 12, 2024

Uh oh!

cyberthirst Aug 13, 2024

Uh oh!

cyberthirst Aug 13, 2024

Uh oh!

cyberthirst Aug 28, 2024

Uh oh!

cyberthirst commented Aug 28, 2024

Uh oh!

codecov bot commented Sep 16, 2024 •

edited

Loading

Uh oh!

pcaversaccio commented Oct 14, 2024

Uh oh!

pcaversaccio left a comment •

edited

Loading

Uh oh!

cyberthirst Mar 17, 2025

Uh oh!

charles-cooper Mar 17, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants


		.. py:function:: raw_create(initcode: Bytes[...], *args, value: uint256 = 0, revert_on_failure: bool = True[, salt: bytes32]) -> address

		Create a physical copy of the runtime code at ``target``. The code at ``target`` is byte-for-byte copied into a newly deployed contract.

Uh oh!

Conversation

charles-cooper commented Aug 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What I did

How I did it

How to verify it

Commit message

Description for the changelog

Cute Animal Picture

Uh oh!

cyberthirst commented Aug 12, 2024

Uh oh!

cyberthirst Aug 13, 2024

Choose a reason for hiding this comment

Uh oh!

cyberthirst Aug 13, 2024

Choose a reason for hiding this comment

Uh oh!

cyberthirst Aug 28, 2024

Choose a reason for hiding this comment

Uh oh!

cyberthirst commented Aug 28, 2024

Uh oh!

codecov bot commented Sep 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

pcaversaccio commented Oct 14, 2024

Uh oh!

pcaversaccio left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cyberthirst Mar 17, 2025

Choose a reason for hiding this comment

Uh oh!

charles-cooper Mar 17, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

charles-cooper commented Aug 8, 2024 •

edited

Loading

codecov bot commented Sep 16, 2024 •

edited

Loading

pcaversaccio left a comment •

edited

Loading