fix[lang]: fix certain varinfo comparisons#4164
Merged
charles-cooper merged 8 commits intovyperlang:masterfrom Aug 7, 2024
Merged
fix[lang]: fix certain varinfo comparisons#4164charles-cooper merged 8 commits intovyperlang:masterfrom
charles-cooper merged 8 commits intovyperlang:masterfrom
Conversation
for `VarInfo`s which are declared in memory, the `VarInfo` initialization is missing `decl_node` and therefore different variables with the same type get detected as overlapping in loop iterator modification detection. this commit properly initializes the `VarInfo`s in memory.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4164 +/- ##
===========================================
- Coverage 91.36% 44.72% -46.65%
===========================================
Files 109 109
Lines 15614 15616 +2
Branches 3436 3437 +1
===========================================
- Hits 14266 6984 -7282
- Misses 919 8028 +7109
- Partials 429 604 +175 ☔ View full report in Codecov by Sentry. |
fix test for rw analysis for AnAssign nodes
cyberthirst
approved these changes
Aug 7, 2024
charles-cooper
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
fix #4163
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture