fix[codegen]: interleaved effects eval for some builtins#4156
Merged
charles-cooper merged 11 commits intovyperlang:masterfrom Mar 17, 2025
Merged
fix[codegen]: interleaved effects eval for some builtins#4156charles-cooper merged 11 commits intovyperlang:masterfrom
charles-cooper merged 11 commits intovyperlang:masterfrom
Conversation
--------- Co-authored-by: trocher <[email protected]>
--------- Co-authored-by: cyberthirst <[email protected]>
--------- Co-authored-by: trocher <[email protected]>
fubuloubu
approved these changes
Jun 18, 2024
cyberthirst
reviewed
Sep 16, 2024
vyper/codegen/core.py
Outdated
| return IRnode.from_list(["seq", do_copy, buf], typ=typ, location=MEMORY) | ||
|
|
||
|
|
||
| # TODO: refactor ensure_in_memory to use this function |
Collaborator
There was a problem hiding this comment.
can we do this within the scope of this PR?
cyberthirst
approved these changes
Sep 16, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4156 +/- ##
=======================================
Coverage 92.26% 92.26%
=======================================
Files 123 123
Lines 17500 17502 +2
Branches 2960 2960
=======================================
+ Hits 16146 16148 +2
Misses 946 946
Partials 408 408 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
an explainer note for the fix - the arguments were cached correctly and in the correct order. however, we cached a pointer, not a value. for example, this test changes the value at the given ptr via the extcall which eventually leads to the bug
the fix copies the value to memory, while the |
charles-cooper
changed the title
charles-cooper
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
follow on to #4157. unblock the behavior, and fix the bad order of eval
fixes #4019
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture