chore[test]: add test for struct member names#3527
Merged
charles-cooper merged 12 commits intovyperlang:masterfrom Mar 17, 2025
Merged
chore[test]: add test for struct member names#3527charles-cooper merged 12 commits intovyperlang:masterfrom
charles-cooper merged 12 commits intovyperlang:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3527 +/- ##
==========================================
+ Coverage 92.24% 92.26% +0.02%
==========================================
Files 123 123
Lines 17500 17500
Branches 2960 2960
==========================================
+ Hits 16142 16146 +4
Misses 946 946
+ Partials 412 408 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
i think reserving those attributes to not be available on structs/enums is kind of ok. |
Member
|
but yea, maybe it's useful sometimes to have structs with information like |
Member
This reverts commit 9de0941.
tserg
changed the title
Member
|
@tserg could you update to the new kwarg syntax? |
Contributor
Author
|
Done! |
charles-cooper
approved these changes
Feb 21, 2025
Member
charles-cooper
left a comment
charles-cooper
left a comment
There was a problem hiding this comment.
lgtm, tagging @cyberthirst to check as well
charles-cooper
requested review from
cyberthirst
and removed request for
cyberthirst
cyberthirst
approved these changes
Mar 16, 2025
charles-cooper
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Fix #3521.
How I did it
Remove the
elsebranch inparse_Attributeso that structs can be catched.How to verify it
See test.
Commit message
Description for the changelog
Allow address members' names as struct fields.
Cute Animal Picture