fix[lang]: extend as_wei_value to all numeric types#3498
Merged
charles-cooper merged 14 commits intovyperlang:masterfrom Mar 18, 2025
Merged
fix[lang]: extend as_wei_value to all numeric types#3498charles-cooper merged 14 commits intovyperlang:masterfrom
as_wei_value to all numeric types#3498charles-cooper merged 14 commits intovyperlang:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3498 +/- ##
=======================================
Coverage 92.26% 92.27%
=======================================
Files 123 123
Lines 17505 17520 +15
Branches 2961 2961
=======================================
+ Hits 16151 16166 +15
Misses 946 946
Partials 408 408 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
@trocher i merged in master and simplified the code paging @cyberthirst for review |
charles-cooper
changed the title
as_wei_value for all numeric typeas_wei_value to all numeric types
cyberthirst
reviewed
Mar 18, 2025
cyberthirst
approved these changes
Mar 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Fixed #3281
How I did it
Added the required IR for all signed and unsigned types.
How to verify it
See the tests.
Commit message
Description for the changelog
implement as_wei_value for all numeric type
Cute Animal Picture