Repository navigation
Commit 4a47b9e
committed
fix(tui): correct the unscoped-endpoint warning for proxy transport
The warning called an endpoint with no protocol an "L4 rule" that "allows every
connection to this host and port". That was accurate when this branch was
written, but NVIDIA#3136 changed what omitting the protocol means: per
openshell_policy::agent_authored_transport_rejection, an omitted protocol keeps
the explicit proxy, which terminates TLS and canonicalizes the HTTP authority,
and protocol: tcp and tls: skip can no longer be agent-authored at all. Calling
that path L4 and describing it as raw connections overstates the exposure and
mislabels the mode.
Describe what is actually broad about it instead: no method or path constraint,
so every request to the host and port is allowed rather than only the denied
one. The two REST branches are unchanged, and the docs paragraph now matches the
transport vocabulary the advisor page uses.
Part of NVIDIA#1098.
Signed-off-by: Vyncint Ng <[email protected]>1 parent 28c14f4 commit 4a47b9e
2 files changed
Lines changed: 20 additions & 12 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
870 | 870 | | |
871 | 871 | | |
872 | 872 | | |
873 | | - | |
874 | | - | |
875 | | - | |
876 | | - | |
877 | | - | |
| 873 | + | |
| 874 | + | |
| 875 | + | |
| 876 | + | |
| 877 | + | |
| 878 | + | |
| 879 | + | |
| 880 | + | |
| 881 | + | |
| 882 | + | |
878 | 883 | | |
879 | 884 | | |
880 | 885 | | |
881 | | - | |
| 886 | + | |
882 | 887 | | |
883 | 888 | | |
884 | 889 | | |
| |||
1455 | 1460 | | |
1456 | 1461 | | |
1457 | 1462 | | |
1458 | | - | |
| 1463 | + | |
1459 | 1464 | | |
1460 | | - | |
| 1465 | + | |
1461 | 1466 | | |
1462 | 1467 | | |
1463 | 1468 | | |
| |||
1494 | 1499 | | |
1495 | 1500 | | |
1496 | 1501 | | |
1497 | | - | |
1498 | | - | |
| 1502 | + | |
| 1503 | + | |
1499 | 1504 | | |
1500 | 1505 | | |
1501 | 1506 | | |
| |||
1504 | 1509 | | |
1505 | 1510 | | |
1506 | 1511 | | |
1507 | | - | |
| 1512 | + | |
| 1513 | + | |
| 1514 | + | |
| 1515 | + | |
1508 | 1516 | | |
1509 | 1517 | | |
1510 | 1518 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
232 | 232 | | |
233 | 233 | | |
234 | 234 | | |
235 | | - | |
| 235 | + | |
236 | 236 | | |
237 | 237 | | |
238 | 238 | | |
| |||
0 commit comments