mounts/validate: Don't check source exists with CreateMountpoint

vvoland · vvoland · commit 05b883bdc836 · 2024-02-23T11:20:55.000+01:00
Don't error out when mount source doesn't exist and mounts has
`CreateMountpoint` option enabled.

Signed-off-by: Paweł Gronowski &lt;pawel.gronowski@docker.com&gt;
diff --git a/volume/mounts/linux_parser.go b/volume/mounts/linux_parser.go
@@ -85,7 +85,9 @@ func (p *linuxParser) validateMountConfigImpl(mnt *mount.Mount, validateBindSour
 			if err != nil {
 				return &errMountConfig{mnt, err}
 			}
-			if !exists {
+
+			createMountpoint := mnt.BindOptions != nil && mnt.BindOptions.CreateMountpoint
+			if !exists && !createMountpoint {
 				return &errMountConfig{mnt, errBindSourceDoesNotExist(mnt.Source)}
 			}
 		}

Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,9 @@ func (p linuxParser) validateMountConfigImpl(mnt mount.Mount, validateBindSour`
`85`	`85`	`if err != nil {`
`86`	`86`	`return &errMountConfig{mnt, err}`
`87`	`87`	`}`
`88`		`- if !exists {`
	`88`	`+`
	`89`	`+ createMountpoint := mnt.BindOptions != nil && mnt.BindOptions.CreateMountpoint`
	`90`	`+ if !exists && !createMountpoint {`
`89`	`91`	`return &errMountConfig{mnt, errBindSourceDoesNotExist(mnt.Source)}`
`90`	`92`	`}`
`91`	`93`	`}`