Add support for psetv2 #189
Conversation
| var script, blindingKey []byte | ||
| if len(a.Address) > 0 { | ||
| script, _ = address.ToOutputScript(a.Address) | ||
| script = []byte{txscript.OP_RETURN} |
There was a problem hiding this comment.
Yes indeed.
OutputArgs is a user-friendly type without a raw field like BlindingPubKey []byte. It instead has a Address string field that can be confidential or unconfidential, and in the first case is used to set also the partial output blinding pubkey.
If the OutputArgs has a confidential address and a 0 amount, it means it's dummy confidential output, therefore only the blinding pubkey extracted from the confidential address is passed to the partial output, while the actual script is OP_RETURN.
There was a problem hiding this comment.
mmm seems not straightforward and doing a lot of implicit things, also how to embed actual data in the OP_RETURN or what if you want to burn funds ie. amount > 0?
I would take advantage of generics type here, to pass both Script && Blinding Key OR Address, to accommodate both situations
tiero
left a comment
tiero
left a comment
There was a problem hiding this comment.
Update the badge in README for the CI status, to point to Github Action badge
tiero
left a comment
tiero
left a comment
There was a problem hiding this comment.
Let's add the BIP371 Taproot fields
3 participants
This contribs to the initial effort of @sekulicd in #184 and takes the psetv2 package to a ready-to-use version.
I made a huge refactor regarding named variables, errors messages, and, more importantly, the business logic.
In particular, the blinder role has been basically split into 2 fundamental parts:
psetv2.Blinderis the role in charge of adding blinding data to pset's input issuances or outputs. It makes sure that everything's correct and updates also the global scalars of the partial transactionconfidential.zkpGeneratorandconfidential.zkpValidatorare the implementations ofpsetv2.BlindingGeneratorandpsetv2.BlindingValidator, in charge of handling private keys to unblind inputs and public keys to generate blinding data, ie. blinders, commitments, and proofsThe package already contains some tests showing how to use psetv2 to:
Please @tiero @sekulicd @louisinger review this.
This closes #167
This closes #189