-
Notifications
You must be signed in to change notification settings - Fork 11
Pubkey issuance contract #183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tiero
merged 33 commits into
vulpemventures:master
from
sekulicd:pubkey-issuance-contract
Nov 23, 2021
Merged
Pubkey issuance contract #183
tiero
merged 33 commits into
vulpemventures:master
from
sekulicd:pubkey-issuance-contract
Nov 23, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
tiero
reviewed
Nov 23, 2021
transaction/issuance.go
Outdated
| return confAmount[:], nil | ||
| } | ||
|
|
||
| func orderJsonKeysLexicographically(bytes []byte) ([]byte, error) { |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| func orderJsonKeysLexicographically(bytes []byte) ([]byte, error) { | |
| func orderJsonKeysLexographically(bytes []byte) ([]byte, error) { |
Collaborator
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds issuer_pubkey to the Issuance.
This close #182
@tiero please review.