Skip to content

Conversation

@sekulicd
Copy link
Collaborator

This adds issuer_pubkey to the Issuance.

This close #182

@tiero please review.

sekulicd added 30 commits May 20, 2020 13:41
@sekulicd
Copy link
Collaborator Author

sekulicd commented Nov 23, 2021

Moving conversation from here to this PR.

@tiero please check test which is passing contract hash validation.

Still old test is failing, @altafan any idea why? where did u find these fixtures?

Ref doc on asset reg.

return confAmount[:], nil
}

func orderJsonKeysLexicographically(bytes []byte) ([]byte, error) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
func orderJsonKeysLexicographically(bytes []byte) ([]byte, error) {
func orderJsonKeysLexographically(bytes []byte) ([]byte, error) {

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@tiero tiero merged commit 2d0a253 into vulpemventures:master Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

the hex-encoded public key of the issuer is missing IssuanceContract struct

2 participants