fix: use isArray util function to check the type of the array#596
Merged
Conversation
`instanceof` check was causing false negative in Nuxt server side env. It's fixed by using `Array.isArray()` instead.
Codecov Report
@@ Coverage Diff @@
## master #596 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 47 47
Lines 1904 1910 +6
Branches 270 270
=====================================
+ Hits 1904 1910 +6
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When checking a value is a type of array, using
foo instanceof Arraywas causing false negative in Nuxt server side env. It's fixed by usingArray.isArray()instead.This PR adds
isArrayutility function, and replaces allArray.isArray()andfoo instanceof Arraycondition checks.Type of PR:
Breaking changes: