Prevent mutation of original data structure in insert/create/insertOrUpdate#564
Merged
Conversation
Ensure the data going in is the same once all the operations have been completed.
Prevent input's original structure from being modified by the Normalizer. resolves vuex-orm#516
Codecov Report
@@ Coverage Diff @@
## master #564 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 47 47
Lines 1837 1838 +1
Branches 255 255
=========================================
+ Hits 1837 1838 +1 Continue to review full report at Codecov.
|
Member
|
Thanks so much, super helpful! Could you import |
Contributor
Author
|
@cuebit No worries, happy to help. And cool, polyfill added |
There was a change in commit `011ea9ab60e799677b593398dd894d3350da7b8a` that got removed in a subsequent PR, and I'm not sure why, but this fixes the error when getting related records
Revert "Update HasManyBy with null/undefined check" This reverts commit 031df9a.
cuebit
added a commit
to cuebit/vuex-orm
that referenced
this pull request
Feb 23, 2020
additionally fixes reference issues resolves vuex-orm#553, vuex-orm#516 closes vuex-orm#564
cuebit
added a commit
to cuebit/vuex-orm
that referenced
this pull request
Feb 23, 2020
additionally fixes reference issues resolves vuex-orm#553, vuex-orm#516 closes vuex-orm#564
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add cloning before normalizing and persisting records to prevent unwanted/unanticipated data mutation.
References: #516
Changes: