Skip to content

Remove deprecated functionality references from docs/tests#543

Merged
kiaking merged 6 commits into
vuex-orm:masterfrom
cuebit:deprecations
Jan 28, 2020
Merged

Remove deprecated functionality references from docs/tests#543
kiaking merged 6 commits into
vuex-orm:masterfrom
cuebit:deprecations

Conversation

@cuebit

@cuebit cuebit commented Jan 28, 2020

Copy link
Copy Markdown
Member

This PR attempts to dissipate the already deprecated increment attribute in the documentation and unit tests.

The attribute increment has been replaced by the newly promoted uid attribute and it makes sense to warn users who update to future releases.

There are various other grammatical and type corrections thrown in for good measure.

@codecov

codecov Bot commented Jan 28, 2020

Copy link
Copy Markdown

Codecov Report

Merging #543 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #543   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          46     46           
  Lines        1854   1854           
  Branches      264    264           
=====================================
  Hits         1854   1854
Impacted Files Coverage Δ
src/model/Model.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43a92a9...3a90b27. Read the comment docs.

@kiaking

kiaking commented Jan 28, 2020

Copy link
Copy Markdown
Member

@cuebit thank you so much! Wow wonderful fixes! 🤝

@kiaking kiaking added bug Something isn't working documentation The issue is about documentation enhancement New feature or request labels Jan 28, 2020
@kiaking kiaking merged commit 87ff400 into vuex-orm:master Jan 28, 2020
@cuebit cuebit mentioned this pull request Feb 1, 2020
@cuebit cuebit deleted the deprecations branch February 2, 2020 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation The issue is about documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants