Skip to content

Comments

fix(nuxt): ensure excludes disabledFunctions' alias#5240

Merged
antfu merged 2 commits intovueuse:mainfrom
jinyongp:fix/nuxt-resolveRef-auto-import
Jan 31, 2026
Merged

fix(nuxt): ensure excludes disabledFunctions' alias#5240
antfu merged 2 commits intovueuse:mainfrom
jinyongp:fix/nuxt-resolveRef-auto-import

Conversation

@jinyongp
Copy link
Contributor

@jinyongp jinyongp commented Jan 4, 2026 •
edited
Loading

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.

Description

Nuxt(v4.2.2) with @vueuse/nuxt(v14.1.0)

resolveRef is auto-imported but does not exist

.nuxt/types/imports.d.ts

Image

resolveRef is being auto-imported even though it does not exist in Vue or VueUse.

I’ve confirmed that this change only removes resolveRef from auto-imports, and nothing else.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jan 4, 2026
@antfu
Copy link
Member

antfu commented Jan 9, 2026

resolveRef is auto-imported but does not exist

I think the root cause is that we should remove the incorrect alias from the function

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 9, 2026

Open in StackBlitz

@vueuse/components

npm i https://pkg.pr.new/@vueuse/components@5240

@vueuse/core

npm i https://pkg.pr.new/@vueuse/core@5240

@vueuse/electron

npm i https://pkg.pr.new/@vueuse/electron@5240

@vueuse/firebase

npm i https://pkg.pr.new/@vueuse/firebase@5240

@vueuse/integrations

npm i https://pkg.pr.new/@vueuse/integrations@5240

@vueuse/math

npm i https://pkg.pr.new/@vueuse/math@5240

@vueuse/metadata

npm i https://pkg.pr.new/@vueuse/metadata@5240

@vueuse/nuxt

npm i https://pkg.pr.new/@vueuse/nuxt@5240

@vueuse/router

npm i https://pkg.pr.new/@vueuse/router@5240

@vueuse/rxjs

npm i https://pkg.pr.new/@vueuse/rxjs@5240

@vueuse/shared

npm i https://pkg.pr.new/@vueuse/shared@5240

commit: 9dff559

@codecov
Copy link

codecov bot commented Jan 9, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.35%. Comparing base (f503bde) to head (7e21a3b).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5240   +/-   ##
=======================================
  Coverage   64.35%   64.35%           
=======================================
  Files         343      343           
  Lines        6641     6641           
  Branches     2030     2018   -12     
=======================================
  Hits         4274     4274           
  Misses       1965     1965           
  Partials      402      402

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jinyongp
Copy link
Contributor Author

jinyongp commented Jan 9, 2026

@antfu
I agree that the unnecessary resolveRef alias should be removed from @vueuse/core.
However, the changes in this PR should still be reflected, since an alias must not exist for a function filtered out by a disabled condition.

@9romise 9romise changed the title fix(nuxt): enhance auto-import filtering for functions fix(nuxt): ensure excludes disabledFunctions' alias Jan 29, 2026
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 29, 2026
@antfu antfu added this pull request to the merge queue Jan 31, 2026
Merged via the queue into vueuse:main with commit 768298c Jan 31, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@9romise 9romise 9romise approved these changes

Assignees

No one assigned

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jinyongp @antfu @9romise