Skip to content

Comments

feat(useElementVisibility): inherit rootMargin from useIntersectionObserver#5207

Merged
antfu merged 1 commit intovueuse:mainfrom
9romise:chore/element-visibility
Dec 12, 2025
Merged

feat(useElementVisibility): inherit rootMargin from useIntersectionObserver#5207
antfu merged 1 commit intovueuse:mainfrom
9romise:chore/element-visibility

Conversation

@9romise
Copy link
Member

@9romise 9romise commented Dec 10, 2025 •
edited
Loading

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.

Description

Follow up to #4934, this can also make rootMargin in useElementVisibility reactive.

Close #4930. Close #4933

Additional context

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Dec 10, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 10, 2025

Open in StackBlitz

@vueuse/components

npm i https://pkg.pr.new/@vueuse/components@5207

@vueuse/core

npm i https://pkg.pr.new/@vueuse/core@5207

@vueuse/electron

npm i https://pkg.pr.new/@vueuse/electron@5207

@vueuse/firebase

npm i https://pkg.pr.new/@vueuse/firebase@5207

@vueuse/integrations

npm i https://pkg.pr.new/@vueuse/integrations@5207

@vueuse/math

npm i https://pkg.pr.new/@vueuse/math@5207

@vueuse/metadata

npm i https://pkg.pr.new/@vueuse/metadata@5207

@vueuse/nuxt

npm i https://pkg.pr.new/@vueuse/nuxt@5207

@vueuse/router

npm i https://pkg.pr.new/@vueuse/router@5207

@vueuse/rxjs

npm i https://pkg.pr.new/@vueuse/rxjs@5207

@vueuse/shared

npm i https://pkg.pr.new/@vueuse/shared@5207

commit: a0dc9b1

@codecov
Copy link

codecov bot commented Dec 10, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.36%. Comparing base (53abedf) to head (a0dc9b1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5207   +/-   ##
=======================================
  Coverage   64.36%   64.36%           
=======================================
  Files         343      343           
  Lines        6586     6586           
  Branches     2001     2013   +12     
=======================================
  Hits         4239     4239           
  Misses       1946     1946           
  Partials      401      401

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@9romise 9romise changed the title refactor(useElementVisibility): inherit rootMargin from useIntersectionObserver feat(useElementVisibility): inherit rootMargin from useIntersectionObserver Dec 10, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 12, 2025
@antfu antfu added this pull request to the merge queue Dec 12, 2025
Merged via the queue into vueuse:main with commit 466823c Dec 12, 2025
8 of 12 checks passed
@9romise 9romise deleted the chore/element-visibility branch December 12, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antfu antfu antfu approved these changes

Assignees

No one assigned

Labels

lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BUG | useElementVisibility | rootMargin marked as responsive, but not implemented

2 participants

@9romise @antfu