Skip to content

Comments

fix(useMagicKeys): handle empty key events to prevent errors#5149

Merged
antfu merged 2 commits intovueuse:mainfrom
babu-ch:fix/bab/key_default
Nov 26, 2025
Merged

fix(useMagicKeys): handle empty key events to prevent errors#5149
antfu merged 2 commits intovueuse:mainfrom
babu-ch:fix/bab/key_default

Conversation

@babu-ch
Copy link
Contributor

@babu-ch babu-ch commented Nov 5, 2025

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.

Description

fixes #5148

Additional context

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Nov 5, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 5, 2025 •
edited
Loading

Open in StackBlitz

@vueuse/components

npm i https://pkg.pr.new/@vueuse/components@5149

@vueuse/core

npm i https://pkg.pr.new/@vueuse/core@5149

@vueuse/electron

npm i https://pkg.pr.new/@vueuse/electron@5149

@vueuse/firebase

npm i https://pkg.pr.new/@vueuse/firebase@5149

@vueuse/integrations

npm i https://pkg.pr.new/@vueuse/integrations@5149

@vueuse/math

npm i https://pkg.pr.new/@vueuse/math@5149

@vueuse/metadata

npm i https://pkg.pr.new/@vueuse/metadata@5149

@vueuse/nuxt

npm i https://pkg.pr.new/@vueuse/nuxt@5149

@vueuse/router

npm i https://pkg.pr.new/@vueuse/router@5149

@vueuse/rxjs

npm i https://pkg.pr.new/@vueuse/rxjs@5149

@vueuse/shared

npm i https://pkg.pr.new/@vueuse/shared@5149

commit: 2b01e0b

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 5, 2025
@OrbisK OrbisK requested review from 43081j and 9romise November 18, 2025 12:16
9romise
9romise reviewed Nov 18, 2025
View reviewed changes
Copy link
Member

@9romise 9romise left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that the KeyboardEvent in the issue was manually dispatched.
Just out of curiosity — does the browser ever dispatch identical KeyboardEvent instances without parameters in certain situations? If not, should we handle this edge case in our codebase rather than expecting users to avoid dispatching such empty events?
I know this is a tiny change, but I'm just wondering — should this really fall under our scope?

@codecov
Copy link

codecov bot commented Nov 18, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.96%. Comparing base (375d1f9) to head (2b01e0b).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5149   +/-   ##
=======================================
  Coverage   63.95%   63.96%           
=======================================
  Files         343      343           
  Lines        7838     7840    +2     
  Branches     2424     2425    +1     
=======================================
+ Hits         5013     5015    +2     
  Misses       2286     2286           
  Partials      539      539

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@antfu antfu enabled auto-merge November 26, 2025 01:36
@antfu antfu added this pull request to the merge queue Nov 26, 2025
Merged via the queue into vueuse:main with commit f8aecd8 Nov 26, 2025
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@9romise 9romise 9romise left review comments

@43081j 43081j 43081j approved these changes

@antfu antfu antfu approved these changes

@OrbisK OrbisK OrbisK approved these changes

Assignees

No one assigned

Labels

lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BUG | useMagicKeys | KeyboardEvent "keyup" with empty string key causes unhandled errors

5 participants

@babu-ch @43081j @antfu @OrbisK @9romise