Skip to content

Comments

fix(useAsyncQueue): trigger onFinished when the last task is rejected#5144

Merged
antfu merged 3 commits intovueuse:mainfrom
keeplearning66:fix/5143
Nov 26, 2025
Merged

fix(useAsyncQueue): trigger onFinished when the last task is rejected#5144
antfu merged 3 commits intovueuse:mainfrom
keeplearning66:fix/5143

Conversation

@keeplearning66
Copy link
Contributor

@keeplearning66 keeplearning66 commented Nov 4, 2025 •
edited
Loading

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.

Description

fix #5143

Additional context

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Nov 4, 2025
@keeplearning66 keeplearning66 changed the title fix(useAsyncQueue): should trigger onFinished when the last task is r… fix(useAsyncQueue): should trigger onFinished when the last task is rejected Nov 4, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 4, 2025 •
edited
Loading

Open in StackBlitz

@vueuse/components

npm i https://pkg.pr.new/@vueuse/components@5144

@vueuse/core

npm i https://pkg.pr.new/@vueuse/core@5144

@vueuse/electron

npm i https://pkg.pr.new/@vueuse/electron@5144

@vueuse/firebase

npm i https://pkg.pr.new/@vueuse/firebase@5144

@vueuse/integrations

npm i https://pkg.pr.new/@vueuse/integrations@5144

@vueuse/math

npm i https://pkg.pr.new/@vueuse/math@5144

@vueuse/metadata

npm i https://pkg.pr.new/@vueuse/metadata@5144

@vueuse/nuxt

npm i https://pkg.pr.new/@vueuse/nuxt@5144

@vueuse/router

npm i https://pkg.pr.new/@vueuse/router@5144

@vueuse/rxjs

npm i https://pkg.pr.new/@vueuse/rxjs@5144

@vueuse/shared

npm i https://pkg.pr.new/@vueuse/shared@5144

commit: 07459fd

@keeplearning66 keeplearning66 changed the title fix(useAsyncQueue): should trigger onFinished when the last task is rejected fix(useAsyncQueue): trigger onFinished when the last task is rejected Nov 4, 2025
@keeplearning66 keeplearning66 mentioned this pull request Nov 4, 2025
Closed
7 tasks
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 4, 2025
@codecov
Copy link

codecov bot commented Nov 14, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.96%. Comparing base (6f79ae1) to head (07459fd).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5144   +/-   ##
=======================================
  Coverage   63.95%   63.96%           
=======================================
  Files         343      343           
  Lines        7838     7840    +2     
  Branches     2424     2425    +1     
=======================================
+ Hits         5013     5015    +2     
  Misses       2286     2286           
  Partials      539      539

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@antfu antfu added this pull request to the merge queue Nov 26, 2025
Merged via the queue into vueuse:main with commit c4a4602 Nov 26, 2025
12 checks passed
@keeplearning66 keeplearning66 deleted the fix/5143 branch December 12, 2025 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OrbisK OrbisK OrbisK approved these changes

@9romise 9romise 9romise approved these changes

Assignees

No one assigned

Labels

lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BUG | useAsyncQueue | In the last task, reject does not trigger the onFinished event

4 participants

@keeplearning66 @OrbisK @9romise @antfu