Skip to content

Comments

fix(types): deprecate embeded ResizeObserverSize types#5127

Merged
antfu merged 3 commits intomainfrom
useResizeObserver/type
Nov 26, 2025
Merged

fix(types): deprecate embeded ResizeObserverSize types#5127
antfu merged 3 commits intomainfrom
useResizeObserver/type

Conversation

@9romise
Copy link
Member

@9romise 9romise commented Oct 30, 2025

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.

Description

This type has been included in TypeScript for nearly 5 years. See: microsoft/TypeScript-DOM-lib-generator#948

Additional context

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Oct 30, 2025
@OrbisK
Copy link
Member

OrbisK commented Oct 30, 2025

These are exported interfaces. Perhaps we should deprecate them first, while still exporting these "old" interfaces.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 30, 2025 •
edited
Loading

Open in StackBlitz

@vueuse/components

npm i https://pkg.pr.new/@vueuse/components@5127

@vueuse/core

npm i https://pkg.pr.new/@vueuse/core@5127

@vueuse/electron

npm i https://pkg.pr.new/@vueuse/electron@5127

@vueuse/firebase

npm i https://pkg.pr.new/@vueuse/firebase@5127

@vueuse/integrations

npm i https://pkg.pr.new/@vueuse/integrations@5127

@vueuse/math

npm i https://pkg.pr.new/@vueuse/math@5127

@vueuse/metadata

npm i https://pkg.pr.new/@vueuse/metadata@5127

@vueuse/nuxt

npm i https://pkg.pr.new/@vueuse/nuxt@5127

@vueuse/router

npm i https://pkg.pr.new/@vueuse/router@5127

@vueuse/rxjs

npm i https://pkg.pr.new/@vueuse/rxjs@5127

@vueuse/shared

npm i https://pkg.pr.new/@vueuse/shared@5127

commit: 13dce4a

@9romise 9romise changed the title fix(types): remove embeded ResizeObserverSize types fix(types): deprecate embeded ResizeObserverSize types Oct 30, 2025
@antfu antfu added this to the 15.0 milestone Oct 31, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 26, 2025
@antfu antfu added this pull request to the merge queue Nov 26, 2025
Merged via the queue into main with commit d7a0701 Nov 26, 2025
5 of 10 checks passed
@antfu antfu deleted the useResizeObserver/type branch November 26, 2025 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antfu antfu antfu approved these changes

Assignees

No one assigned

Labels

lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

15.0

Development

Successfully merging this pull request may close these issues.

3 participants

@9romise @OrbisK @antfu