Skip to content

Comments

feat(onClickOutside): allow the value of target to be a getter#5098

Merged
43081j merged 3 commits intovueuse:mainfrom
keeplearning66:feat/5095
Oct 15, 2025
Merged

feat(onClickOutside): allow the value of target to be a getter#5098
43081j merged 3 commits intovueuse:mainfrom
keeplearning66:feat/5095

Conversation

@keeplearning66
Copy link
Contributor

@keeplearning66 keeplearning66 commented Oct 15, 2025 •
edited by OrbisK
Loading

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.

Description

resolve #5095
Can I directly use MaybeComputedElementRef instead of MaybeElementRefOrGetter mentioned in #5095? 🤔

Additional context

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. enhancement New feature or request labels Oct 15, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 15, 2025 •
edited
Loading

Open in StackBlitz

@vueuse/components

npm i https://pkg.pr.new/@vueuse/components@5098

@vueuse/core

npm i https://pkg.pr.new/@vueuse/core@5098

@vueuse/electron

npm i https://pkg.pr.new/@vueuse/electron@5098

@vueuse/firebase

npm i https://pkg.pr.new/@vueuse/firebase@5098

@vueuse/integrations

npm i https://pkg.pr.new/@vueuse/integrations@5098

@vueuse/math

npm i https://pkg.pr.new/@vueuse/math@5098

@vueuse/metadata

npm i https://pkg.pr.new/@vueuse/metadata@5098

@vueuse/nuxt

npm i https://pkg.pr.new/@vueuse/nuxt@5098

@vueuse/router

npm i https://pkg.pr.new/@vueuse/router@5098

@vueuse/rxjs

npm i https://pkg.pr.new/@vueuse/rxjs@5098

@vueuse/shared

npm i https://pkg.pr.new/@vueuse/shared@5098

commit: 097307e

@codecov
Copy link

codecov bot commented Oct 15, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.78%. Comparing base (6c4294d) to head (097307e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5098      +/-   ##
==========================================
+ Coverage   66.75%   66.78%   +0.02%     
==========================================
  Files         365      365              
  Lines       14564    14579      +15     
  Branches     2410     2413       +3     
==========================================
+ Hits         9722     9736      +14     
- Misses       4831     4832       +1     
  Partials       11       11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@OrbisK
Copy link
Member

OrbisK commented Oct 15, 2025

Thank you for your quick PR 🙏🏽 Would you mind adding a test that covers this?

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Oct 15, 2025
OrbisK
OrbisK previously approved these changes Oct 15, 2025
View reviewed changes
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 15, 2025
@keeplearning66
Copy link
Contributor Author

keeplearning66 commented Oct 15, 2025

Done, thank you for the reminder. 😃

@keeplearning66
Copy link
Contributor Author

keeplearning66 commented Oct 15, 2025

Sorry for my oversight. I think renaming complexComponent to getComplexComponent might be better. 👀

@keeplearning66 keeplearning66 requested a review from OrbisK October 15, 2025 07:37
@43081j 43081j added this pull request to the merge queue Oct 15, 2025
Merged via the queue into vueuse:main with commit 7133cfe Oct 15, 2025
12 checks passed
@keeplearning66 keeplearning66 deleted the feat/5095 branch October 25, 2025 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@43081j 43081j 43081j approved these changes

@OrbisK OrbisK OrbisK approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

onClickOutside | Accept getter as target

3 participants

@keeplearning66 @OrbisK @43081j