fix(integrations): use relative import in component.ts#5025
Merged
antfu merged 2 commits intovueuse:mainfrom Sep 12, 2025
Merged
fix(integrations): use relative import in component.ts#5025antfu merged 2 commits intovueuse:mainfrom
component.ts#5025antfu merged 2 commits intovueuse:mainfrom
Conversation
dosubot
bot
added
the
size:S
5 tasks
@vueuse/components
@vueuse/core
@vueuse/electron
@vueuse/firebase
@vueuse/integrations
@vueuse/math
@vueuse/metadata
@vueuse/nuxt
@vueuse/router
@vueuse/rxjs
@vueuse/shared
commit: |
9romise
changed the title
components
9romise
changed the title
componentscomponent.ts
antfu
requested changes
Sep 10, 2025
| import { useFocusTrap } from '@vueuse/integrations/useFocusTrap' | ||
| import type { UseFocusTrapOptions, UseFocusTrapReturn } from './index' | ||
| import { defineComponent, h, reactive, shallowRef } from 'vue' | ||
| import { useFocusTrap } from './index' |
Member
There was a problem hiding this comment.
I think this was on purpose, otherwise the functions would be duplicated in the /components bundle. Instead, we should limit to not use ./index in component.ts
Member
Author
There was a problem hiding this comment.
Actually, it won’t be bundled repeatedly — it imports a hashed file where duplicate logic has been extracted. See #5021 (comment).
Since @vueuse/integrations isn’t part of @vueuse/components and only references content within its own package, I think it doesn’t need to import using a full package name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting the PR, please make sure you do the following
fixes #123).Description
#5021 (comment)
Additional context