Skip to content

Comments

feat(onLongPress): allow function as value in delay#4979

Merged
antfu merged 4 commits intovueuse:mainfrom
keeplearning66:feat/onLongPress
Aug 29, 2025
Merged

feat(onLongPress): allow function as value in delay#4979
antfu merged 4 commits intovueuse:mainfrom
keeplearning66:feat/onLongPress

Conversation

@keeplearning66
Copy link
Contributor

@keeplearning66 keeplearning66 commented Aug 22, 2025 •
edited
Loading

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.

Description

This PR is to resolve #4978
I added getDelay to get the final delay value.

Additional context

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. enhancement New feature or request new function labels Aug 22, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Aug 22, 2025 •
edited
Loading

Open in StackBlitz

@vueuse/components

npm i https://pkg.pr.new/@vueuse/components@4979

@vueuse/core

npm i https://pkg.pr.new/@vueuse/core@4979

@vueuse/electron

npm i https://pkg.pr.new/@vueuse/electron@4979

@vueuse/firebase

npm i https://pkg.pr.new/@vueuse/firebase@4979

@vueuse/integrations

npm i https://pkg.pr.new/@vueuse/integrations@4979

@vueuse/math

npm i https://pkg.pr.new/@vueuse/math@4979

@vueuse/metadata

npm i https://pkg.pr.new/@vueuse/metadata@4979

@vueuse/nuxt

npm i https://pkg.pr.new/@vueuse/nuxt@4979

@vueuse/router

npm i https://pkg.pr.new/@vueuse/router@4979

@vueuse/rxjs

npm i https://pkg.pr.new/@vueuse/rxjs@4979

@vueuse/shared

npm i https://pkg.pr.new/@vueuse/shared@4979

commit: 68348ec

@9romise 9romise mentioned this pull request Aug 22, 2025
Closed
4 tasks
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 22, 2025
@NoiseFan NoiseFan mentioned this pull request Aug 23, 2025
Closed
5 tasks
@OrbisK OrbisK requested a review from 43081j August 28, 2025 09:14
@43081j
Copy link
Collaborator

43081j commented Aug 28, 2025

before we merge this (if we do), i've posted this:
#4978 (comment)

as i want to be sure there's actually need for this

@keeplearning66
Copy link
Contributor Author

keeplearning66 commented Aug 28, 2025

before we merge this (if we do), i've posted this: #4978 (comment)

as i want to be sure there's actually need for this

Okay, thank you for your reply

43081j
43081j reviewed Aug 28, 2025
View reviewed changes
@antfu antfu added this pull request to the merge queue Aug 29, 2025
Merged via the queue into vueuse:main with commit 415f376 Aug 29, 2025
10 checks passed
This was referenced Sep 1, 2025
Closed
Closed
Closed
@keeplearning66 keeplearning66 deleted the feat/onLongPress branch October 25, 2025 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@43081j 43081j 43081j left review comments

@antfu antfu antfu approved these changes

@OrbisK OrbisK OrbisK approved these changes

@ilyaliao ilyaliao ilyaliao approved these changes

+1 more reviewer

@VividLemon VividLemon VividLemon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or request lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

onLongPress | Allow function as value in delay

6 participants

@keeplearning66 @43081j @antfu @VividLemon @OrbisK @ilyaliao