fix(useMouseInElement): allow el to be instanceof Element#4189
Merged
antfu merged 1 commit intovueuse:mainfrom Sep 12, 2024
Merged
fix(useMouseInElement): allow el to be instanceof Element#4189antfu merged 1 commit intovueuse:mainfrom
el to be instanceof Element#4189antfu merged 1 commit intovueuse:mainfrom
Conversation
5 tasks
el to be instanceof Element
antfu
approved these changes
Sep 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting the PR, please make sure you do the following
fixes #123).Description
In version 11 of vueuse the
useMouseInElementcomposable stopped working for SVG elements as it did before. There wasinstanceof HTMLElementcheck added which is a bit too strict:instanceof Elementis enough and fixes usage in SVG-element use case.Additional context
The regression was added as a part of this PR.