Skip to content

Comments

feat(useFileDialog): return onCancel handler#4184

Merged
antfu merged 2 commits intovueuse:mainfrom
AndreyYolkin:main
Sep 12, 2024
Merged

feat(useFileDialog): return onCancel handler#4184
antfu merged 2 commits intovueuse:mainfrom
AndreyYolkin:main

Conversation

@AndreyYolkin
Copy link
Contributor

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.


Description

Implements #4183 proposal

This PR extends returned options from useFileDialog with additional onCancel handler, which allows developers to handle situations when user denied file selection

Additional context

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. enhancement New feature or request labels Aug 29, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 12, 2024
@antfu antfu added this pull request to the merge queue Sep 12, 2024
Merged via the queue into vueuse:main with commit 30452c2 Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants