Skip to content

Comments

fix(usePermission): fix memory leak#4157

Merged
antfu merged 1 commit intovueuse:mainfrom
ferferga:fix-usePermission-leak
Aug 19, 2024
Merged

fix(usePermission): fix memory leak#4157
antfu merged 1 commit intovueuse:mainfrom
ferferga:fix-usePermission-leak

Conversation

@ferferga
Copy link
Member

@ferferga ferferga commented Aug 17, 2024

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.

Description

Close #4154 and fix #4149

By converting permissionStatus to a ref, useEventListener is able to properly retrack the event target, disposing everything accordingly.

Additional context

  • state has been converted to shallowRef to match permissionStatus and improve performance, since we don't need deep tracking.
  • An small refactor to how the composable works has also been proposed to be shipped as part of this PR here, so please take a look to that message (and further discussion) side-to-side while reviewing this PR.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Aug 17, 2024
@ferferga ferferga mentioned this pull request Aug 17, 2024
Closed
7 tasks
@dosubot dosubot bot added the enhancement New feature or request label Aug 17, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 19, 2024
@antfu antfu added this pull request to the merge queue Aug 19, 2024
@antfu antfu changed the title perf(usePermission): fix memory leak fix(usePermission): fix memory leak Aug 19, 2024
Merged via the queue into vueuse:main with commit 63a22fa Aug 19, 2024
@ferferga ferferga deleted the fix-usePermission-leak branch August 21, 2024 08:46
This was referenced Sep 10, 2024
Closed
Closed
Closed
Closed
Closed
@gn00029914 gn00029914 mentioned this pull request Sep 24, 2024
Closed
@renovate renovate bot mentioned this pull request Jun 1, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antfu antfu antfu approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

usePermission creates memory leaks

2 participants

@ferferga @antfu