Skip to content

Comments

fix(useFocusWithin): make useFocusWhithin match the behavior of the :focus-within#4134

Merged
antfu merged 3 commits intovueuse:mainfrom
ben-lau:main
Sep 12, 2024
Merged

fix(useFocusWithin): make useFocusWhithin match the behavior of the :focus-within#4134
antfu merged 3 commits intovueuse:mainfrom
ben-lau:main

Conversation

@ben-lau
Copy link
Contributor

@ben-lau ben-lau commented Aug 7, 2024

This PR make useFocusWithin match the behavior of the :focus-within CSS pseudo-class. In this demo, when you focus out of the browser, the form will still be considered focused by vueuse. I use focusin and focusout event to make it match the behavior.

Solved #4083

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.


Description

Additional context

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Aug 7, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 12, 2024
@antfu antfu enabled auto-merge September 12, 2024 14:12
@antfu antfu added this pull request to the merge queue Sep 12, 2024
Merged via the queue into vueuse:main with commit c540701 Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants