fix(useChangeCase): use the exported key for filter#4130
Merged
antfu merged 3 commits intovueuse:mainfrom Aug 13, 2024
Merged
Conversation
dosubot
bot
added
the
size:XS
Contributor
Author
|
It seems I didnt linted before uploading ... |
Contributor
|
Sorry to see this PR, I didn't see it linked to the issue, so I made a duplicate version #4140. If you are willing to change the title and link it to the issue #4139, I will close my PR. Thank you. Our solution is consistent, I am sure it actually solves the problem and I have verified it in the |
thyngster
changed the title
antfu
approved these changes
Aug 13, 2024
This was referenced Sep 7, 2024
7 tasks
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changeCaseTransforms will return a null object of funcions becasue on the non-dev build the functions names comes minified/mangles,
making the v.name.endsWith('Case') never maching.
Not sure this is the best aproach to fix. changed Object.values to use Object.entries in other to be able to use theyh object key instead of the function name.
Issue: #4139
Duplicate PR: #4140