Skip to content

Comments

feat(useChangeCase)!: migrate to change-case@v5, closes #3457#3460

Merged
antfu merged 5 commits intomainfrom
fix/useChangeCase
Jun 12, 2024
Merged

feat(useChangeCase)!: migrate to change-case@v5, closes #3457#3460
antfu merged 5 commits intomainfrom
fix/useChangeCase

Conversation

@wheatjs
Copy link
Member

@wheatjs wheatjs commented Oct 6, 2023 •
edited by ghost
Loading

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.

Description

Closes #3457

I've updated the function so we are no longer explicitly importing the change case functions. This should hopefully help future proof the function to any changes in naming made on their end. Also updated to parameters to allow refs and getters.

🤖 Generated by Copilot at 0473413

Refactored and improved the useChangeCase hook and demo. The hook now uses the change-case library and accepts reactive arguments. The demo is more concise and uses the library directly. The changeCase.ts file was removed as it was no longer needed.

🤖 Generated by Copilot at 0473413

  • Simplify and refactor useChangeCase hook to use change-case library directly (link, link, link, link)
  • Delete custom changeCase.ts file (link)
  • Derive ChangeCaseType type from library's exported keys (link)
  • Create changeCaseTransforms object to map case names to functions (link)
  • Use toValue helper to handle reactive type and options arguments (link)
  • Generate transforms array dynamically from library's functions in demo.vue (link)
  • Remove empty style tag from demo.vue (link)
  • Increase radio button width in demo.vue (link)

@antfu antfu changed the title fix: closes #3457 fix(integrations): migrate to change-case@v5 closes #3457 Oct 7, 2023
@antfu antfu changed the title fix(integrations): migrate to change-case@v5 closes #3457 fix(integrations): migrate to change-case@v5, closes #3457 Oct 7, 2023
@antfu antfu changed the title fix(integrations): migrate to change-case@v5, closes #3457 feat(integrations): migrate to change-case@v5, closes #3457 Oct 7, 2023
@ChrisToxz
Copy link

ChrisToxz commented Nov 1, 2023

Any change this will be merged soon?
https://vueuse.org/integrations/useChangeCase/ seems to be useless now.

@wheatjs wheatjs mentioned this pull request Nov 7, 2023
Closed
5 tasks
@antfu antfu changed the title feat(integrations): migrate to change-case@v5, closes #3457 feat(integrations)!: migrate to change-case@v5, closes #3457 Nov 9, 2023
@stale
Copy link

stale bot commented Jan 8, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 8, 2024
@wheatjs wheatjs removed the stale label Jan 9, 2024
@cosmolsmith
Copy link

cosmolsmith commented Feb 27, 2024

Running into this too. useChangeCase is broken.

@doutatsu
Copy link

doutatsu commented Mar 11, 2024

bumping this

@antfu antfu added this to the 11.0 milestone Jun 12, 2024
@antfu antfu self-requested a review June 12, 2024 11:26
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jun 12, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 12, 2024
@antfu antfu enabled auto-merge June 12, 2024 11:53
@antfu antfu changed the title feat(integrations)!: migrate to change-case@v5, closes #3457 feat(useChangeCase)!: migrate to change-case@v5, closes #3457 Jun 12, 2024
@antfu antfu added this pull request to the merge queue Jun 12, 2024
Merged via the queue into main with commit df343af Jun 12, 2024
@antfu antfu deleted the fix/useChangeCase branch June 12, 2024 12:00
This was referenced Sep 7, 2024
Closed
Closed
This was referenced Sep 7, 2024
Closed
Closed
Closed
Closed
Closed
@gn00029914 gn00029914 mentioned this pull request Sep 15, 2024
Closed
@gn00029914 gn00029914 mentioned this pull request Sep 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antfu antfu antfu approved these changes

Assignees

No one assigned

Labels

BREAKING CHANGE lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

11.0

Development

Successfully merging this pull request may close these issues.

useChangeCase: Breaking change on change-case

5 participants

@wheatjs @ChrisToxz @cosmolsmith @doutatsu @antfu