Skip to content

Pushing params without path broken in 3.4.2 #3289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Flowm opened this issue Aug 10, 2020 · 3 comments
Closed

Pushing params without path broken in 3.4.2 #3289

Flowm opened this issue Aug 10, 2020 · 3 comments
Assignees
Labels

Comments

@Flowm
Copy link

Flowm commented Aug 10, 2020

Version

3.4.2

Reproduction link

https://codepen.io/flowm/pen/xxVGYZq?editors=1011

Steps to reproduce

After updating vue-router from 3.4.1 to 3.4.2 a router.push() with only query params causes navigation to an empty path.

Clicking the "Push query" in the codepen triggers such a call which results in the root component to stop being rendered.

What is expected?

The path query params should be updated.

What is actually happening?

The path query params are updated, but the router also navigates to an empty path causing router-view to be empty after the call.


Issue seems to be caused by the different code path taken for query param updates after 4fbaa9f. Reverting this commit restores the old behaviour that allows router.push() with only query params.

@posva posva added the bug label Aug 10, 2020
@posva posva self-assigned this Aug 10, 2020
@posva posva closed this as completed in bcc9ef5 Aug 10, 2020
@posva
Copy link
Member

posva commented Aug 10, 2020

I reverted the change: it was fixing a feature that doesn't exist in v3

@posva
Copy link
Member

posva commented Aug 10, 2020

Thanks for reporting and the investigation!

@Flowm
Copy link
Author

Flowm commented Aug 10, 2020

Thanks for the fast response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants