fix(query): cast query values to strings (fix #2131) (#3232)

MohamedAhmed12 · mohamed.gad · posva · web-flow · commit f0d9c2d93cf0 · 2020-06-18T15:56:51.000+02:00
* fix(query): Fix query props should be casted into string (fix #2131) * Apply suggestions from code review * Update test/unit/specs/query.spec.js Co-authored-by: mohamed.gad <mohamed.gad2622@gmail.com> Co-authored-by: Eduardo San Martin Morote <posva@users.noreply.github.com>
diff --git a/src/util/query.js b/src/util/query.js
@@ -29,7 +29,8 @@ export function resolveQuery (
     parsedQuery = {}
   }
   for (const key in extraQuery) {
-    parsedQuery[key] = extraQuery[key]
+    const value = extraQuery[key]
+    parsedQuery[key] = Array.isArray(value) ? value.map(v => '' + v) : '' + value
   }
   return parsedQuery
 }
diff --git a/test/unit/specs/query.spec.js b/test/unit/specs/query.spec.js
@@ -19,6 +19,15 @@ describe('Query utils', () => {
         arr: ['1', null, '2']
       })
     })
+
+    it('should cast query values into string', () => {
+      const query = resolveQuery('foo=bar&foo=k', { baz: 1 })
+      expect(query.baz).toBe('1')
+    })
+    it('should cast query array values into string', () => {
+      const query = resolveQuery('foo=bar&foo=k', { baz: [1, '2'] })
+      expect(query.baz).toEqual(['1', '2'])
+    })
   })
 
   describe('stringifyQuery', () => {

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,8 @@ export function resolveQuery (`
`29`	`29`	`parsedQuery = {}`
`30`	`30`	`}`
`31`	`31`	`for (const key in extraQuery) {`
`32`		`- parsedQuery[key] = extraQuery[key]`
	`32`	`+ const value = extraQuery[key]`
	`33`	`+ parsedQuery[key] = Array.isArray(value) ? value.map(v => '' + v) : '' + value`
`33`	`34`	`}`
`34`	`35`	`return parsedQuery`
`35`	`36`	`}`