Skip to content

feat: add deprecation message lib #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eddyerburgh merged 1 commit into from
Oct 5, 2018
Merged

feat: add deprecation message lib #113

eddyerburgh merged 1 commit into from
Oct 5, 2018

Conversation

@justinhelmer
Copy link
Contributor

@justinhelmer justinhelmer commented Oct 5, 2018

Prerequisite for #111 (deprecating babelRcFile, tsConfigFile)

@justinhelmer justinhelmer mentioned this pull request Oct 5, 2018
Merged
eddyerburgh
eddyerburgh requested changes Oct 5, 2018
View reviewed changes
Copy link
Member

@eddyerburgh eddyerburgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use the logger.warn rather than console.warn—https://github.com/vuejs/vue-jest/blob/master/lib/logger.js.

@justinhelmer
Copy link
Contributor Author

justinhelmer commented Oct 5, 2018 •
edited
Loading

Apologies for not spotting that. Squashed and pushed.

EDIT: also made one minor change to prefer mockRestore to managing a reference to the original function.

@justinhelmer
Copy link
Contributor Author

justinhelmer commented Oct 5, 2018 •
edited
Loading

One thing to mention - I was noticing the output was a bit funky and inconsistent. It would only print a few lines or even part of a line. I tried playing with process.stdout.write but no luck. Nothing aside from logging the same thing multiple times would ensure the warning would be logged to completion.

I did some digging and found jestjs/jest#3853 and jestjs/jest#2441 so I concluded there wasn't much we can do until those are resolved.

@eddyerburgh eddyerburgh merged commit 89cd5f3 into vuejs:master Oct 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eddyerburgh eddyerburgh eddyerburgh approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@justinhelmer @eddyerburgh