Skip to content

Allow babelInlineConfig to be passed in #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Globegitter wants to merge 5 commits into from
Closed

Allow babelInlineConfig to be passed in #100

Globegitter wants to merge 5 commits into from

Conversation

@Globegitter
Copy link

@Globegitter Globegitter commented Aug 17, 2018 •
edited
Loading

We are creating our babelConfig programatically and with babel-jest it is already possible to pass that in, but not here. With these changes I can now write my custom vue-jest transform in the following way:

...
module.exports = {
    process(src, filename, jestConfig) {
        return vueJest.process(src, filename, jestConfig, {}, babelOptions);
    },
};

@Globegitter
Copy link
Author

Globegitter commented Aug 30, 2018

Tests are passing now.

@eddyerburgh
Copy link
Member

eddyerburgh commented Aug 31, 2018

I think this should be added to the Jest config option object, rather than added as an extra object. Could you also please add some tests?

@justinhelmer justinhelmer mentioned this pull request Oct 3, 2018
Merged
@justinhelmer
Copy link
Contributor

justinhelmer commented Oct 3, 2018

@eddyerburgh - done. Check #110 / #111 .

@justinhelmer
Copy link
Contributor

justinhelmer commented Oct 6, 2018

I believe this PR can be closed now that #111 has been merged.

@eddyerburgh eddyerburgh closed this Oct 7, 2018
@Globegitter
Copy link
Author

Globegitter commented Oct 29, 2018

@justinhelmer thanks for that I will check it out but it does sound good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Globegitter @eddyerburgh @justinhelmer