feat: add skipLibCheck option in the TS template (defaults to true)#5688
Merged
haoqunjiang merged 1 commit intovuejs:devfrom Jul 16, 2020
Merged
feat: add skipLibCheck option in the TS template (defaults to true)#5688haoqunjiang merged 1 commit intovuejs:devfrom
skipLibCheck option in the TS template (defaults to true)#5688haoqunjiang merged 1 commit intovuejs:devfrom
Conversation
cexbrayat
approved these changes
Jul 15, 2020
Member
cexbrayat
left a comment
There was a problem hiding this comment.
LGTM
FYI: to be accurate, the change was later reverted in Angular CLI (see angular/angular-cli@a42f580) because of the downside of not checking the local d.ts files. It is currently not enabled by default, but that doesn't change anything to your points 👍
4 tasks
5 tasks
peace-maker
added a commit
to spq/pkappa2
that referenced
this pull request
Aug 5, 2024
"Both TypeScript and Vue minor version updates, though as widely tested as they can go, still have chances to break existing type definitions. Users' projects should not break because of code they can't control." vuejs/pinia#2605 vuejs/vue-cli#5688
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References:
tsc --initMake skipLibCheck: true the default in --init microsoft/TypeScript#37808 noEmit and skipLibCheck should be on by default in TS compiler options jaredpalmer/tsdx#529 (comment)create-react-appSpeed up TypeScript projects facebook/create-react-app#5903skipLibCheckto workspace tsconfig angular/angular-cli#16682 Don't enableskipLibCheckin--strictmode angular/angular-cli#16696Pros:
skipLibCheckbrings a better experience.Cons:
.d.tsfiles, including the user-owned ones, which isn't ideal. We should turn on type checking for.d.tsfiles in the project once TypeScript provides such an option.allowSyntheticDefaultImports:trueorskipLibCheck:truein every React project? facebook/create-react-app#8964)/cc @cexbrayat
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Other information: