Repository navigation
fix: do not crash findComponent if ref points to an svg element - #2983
Merged
Merged
Conversation
✅ Deploy Preview for vue-test-utils-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
findComponent({ ref })only treatedHTMLElementrefs as DOM elements. A ref on an<svg>(or any other SVG or MathML element) was passed tocreateVueWrapperas if it were a component instance, and that crashes inhasSetupState:getComponent({ ref })threw the same TypeError instead of the usual "Unable to get component with ref ..." error. This changes the guard toinstanceof Node, whichfind({ ref })already uses, so every DOM element ref gets the empty wrapper that HTML element refs already get. Component refs are never nodes, so they are not affected.pnpm vitest run tests/findComponent.spec.ts(the new test fails on main with the TypeError and passes with the fix)pnpm vitest run(511 passed, 1 todo) andpnpm run test:buildafter a build (same result)pnpm run lint(no new warnings),pnpm run format-check,pnpm run vue-tsc,pnpm run tsd