Skip to content

docs: Add favicon to docs in vitepress config #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 16, 2020
Merged

docs: Add favicon to docs in vitepress config #594

merged 1 commit into from
Nov 16, 2020

Conversation

joostdelange
Copy link
Contributor

@joostdelange joostdelange commented Nov 15, 2020 •
edited
Loading

close #589

@joostdelange joostdelange changed the title fix(#588): Add favicon to docs in vitepress config fix(#588): Add favicon to docs in vitepress config (close #28) Nov 15, 2020
@joostdelange joostdelange changed the title fix(#588): Add favicon to docs in vitepress config (close #28) fix(#588): Add favicon to docs in vitepress config (close #589) Nov 15, 2020
@joostdelange joostdelange changed the title fix(#588): Add favicon to docs in vitepress config (close #589) fix(docs): Add favicon to docs in vitepress config (close #589) Nov 15, 2020
@joostdelange joostdelange changed the title fix(docs): Add favicon to docs in vitepress config (close #589) fix(docs): Add favicon to docs in vitepress config Nov 15, 2020
@joostdelange
Copy link
Contributor Author

Sorry for all the mess above here, still figuring out how Github issues/pull requests work 😬

posva
posva reviewed Nov 16, 2020
View reviewed changes
Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@posva posva changed the title fix(docs): Add favicon to docs in vitepress config docs: Add favicon to docs in vitepress config Nov 16, 2020
@posva posva merged commit 656a2d7 into vuejs:master Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@posva posva

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add favicon to docs
2 participants
@joostdelange @posva