Skip to content

feat: explicit injection symbols in dev mode #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2020

Conversation

cexbrayat
Copy link
Member

Instead of Vue throwing injection "Symbol(r)" not found. when the router is not provided, it now throws a more explicit error in DEV mode:

injection "Symbol([view router]: router)" not found.

I think it gives a better hint to developers when encountering this issue.

Instead of Vue throwing `injection "Symbol(r)" not found.` when the router is not provided, it now throws a more explicit error in DEV mode:

    injection "Symbol([view router]: router)" not found.
Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@posva posva changed the title fix: explicit injection symbols in dev mode feat: explicit injection symbols in dev mode May 9, 2020
@posva posva merged commit fab88ee into vuejs:master May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants