Skip to content

parseQuery override for end user & test #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Mar 17, 2020
Merged

parseQuery override for end user & test #136

merged 11 commits into from
Mar 17, 2020

Conversation

BboyAkers
Copy link
Contributor

Let me know what you think!

@BboyAkers BboyAkers changed the title Built parseQuery override for end user & test Linked parseQuery override for end user & test Mar 15, 2020
@BboyAkers BboyAkers changed the title Linked parseQuery override for end user & test parseQuery override for end user & test Mar 15, 2020
posva
posva requested changes Mar 15, 2020
View reviewed changes
Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the package-lock.json file? We use yarn in the project so that file should not be committed, only yarn.lock should

@BboyAkers
Copy link
Contributor Author

Thanks! I'll start working on it first thing tomorrow!

posva
posva requested changes Mar 16, 2020
View reviewed changes
@posva
Copy link
Member

posva commented Mar 16, 2020

You have a lint:fix command that formats the code: npm run lint:fix

@BboyAkers
Copy link
Contributor Author

Done! Thoughts?

posva
posva approved these changes Mar 17, 2020
View reviewed changes
Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @BboyAkers !
There are few minor things like wording that I will fix locally but the rest is good!

@posva posva merged commit 5dce7bc into vuejs:master Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@posva posva

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BboyAkers @posva