fix(types): allow components defined via defineComponent (#421)

posva · cexbrayat · web-flow · commit e47c84c74a97 · 2020-08-31T11:11:16.000+02:00
Co-authored-by: cexbrayat &lt;cedric@ninja-squad.com&gt;
diff --git a/src/RouterView.ts b/src/RouterView.ts
@@ -62,7 +62,7 @@ export const RouterViewImpl = defineComponent({
           : null
       }
 
-      // props from route configration
+      // props from route configuration
       const routePropsOption = matchedRoute.props[props.name]
       const routeProps = routePropsOption
         ? routePropsOption === true
diff --git a/src/types/index.ts b/src/types/index.ts
@@ -1,6 +1,6 @@
 import { LocationQuery, LocationQueryRaw } from '../query'
 import { PathParserOptions } from '../matcher'
-import { Ref, ComputedRef, Component, ComponentPublicInstance } from 'vue'
+import { Ref, ComputedRef, ComponentPublicInstance, Component } from 'vue'
 import { RouteRecord, RouteRecordNormalized } from '../matcher/types'
 import { HistoryState } from '../history/common'
 import { NavigationFailure } from '../errors'
diff --git a/test-dts/createRouter.test-d.ts b/test-dts/createRouter.test-d.ts
@@ -5,13 +5,40 @@ import {
   NavigationGuardNext,
   RouteLocationNormalized,
 } from './index'
-import { createApp, defineComponent } from 'vue'
+import { createApp, defineComponent, h } from 'vue'
 
 const component = defineComponent({})
 
+const WithProps = defineComponent({
+  props: {
+    id: {
+      type: String,
+      required: true,
+    },
+  },
+})
+
+const Foo = defineComponent({
+  props: {
+    test: String,
+  },
+  setup() {
+    return {
+      title: 'homepage',
+    }
+  },
+  render() {
+    return h('div', `${this.title}: ${this.test}`)
+  },
+})
+
 const router = createRouter({
   history: createWebHistory(),
-  routes: [{ path: '/', component }],
+  routes: [
+    { path: '/', component },
+    { path: '/foo', component: Foo },
+    { path: '/', component: WithProps },
+  ],
   parseQuery: search => ({}),
   stringifyQuery: query => '',
   strict: true,

Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,7 @@ export const RouterViewImpl = defineComponent({`
`62`	`62`	`: null`
`63`	`63`	`}`
`64`	`64`
`65`		`- // props from route configration`
	`65`	`+ // props from route configuration`
`66`	`66`	`const routePropsOption = matchedRoute.props[props.name]`
`67`	`67`	`const routeProps = routePropsOption`
`68`	`68`	`? routePropsOption === true`