fix(location): correctly parse url ending with .

posva · posva · commit cc6e255b9c57 · 2022-11-28T09:18:57.000+01:00
Fix #1620
diff --git a/packages/router/__tests__/location.spec.ts b/packages/router/__tests__/location.spec.ts
@@ -353,6 +353,18 @@ describe('resolveRelativePath', () => {
     expect(resolveRelativePath('/add', '/users/posva')).toBe('/add')
   })
 
+  it('works without anything after the .', () => {
+    expect(resolveRelativePath('./', '/users/posva')).toBe('/users/')
+    expect(resolveRelativePath('.', '/users/posva')).toBe('/users/')
+  })
+
+  it('works without anything after the ..', () => {
+    expect(resolveRelativePath('../', '/users/posva/new')).toBe('/users/')
+    expect(resolveRelativePath('../../', '/users/posva/a/b')).toBe('/users/')
+    expect(resolveRelativePath('..', '/users/posva/new')).toBe('/users/')
+    expect(resolveRelativePath('../..', '/users/posva/a/b')).toBe('/users/')
+  })
+
   it('resolves empty path', () => {
     expect(resolveRelativePath('', '/users/posva')).toBe('/users/posva')
     expect(resolveRelativePath('', '/users')).toBe('/users')
diff --git a/packages/router/src/location.ts b/packages/router/src/location.ts
@@ -212,6 +212,13 @@ export function resolveRelativePath(to: string, from: string): string {
 
   const fromSegments = from.split('/')
   const toSegments = to.split('/')
+  const lastToSegment = toSegments[toSegments.length - 1]
+
+  // make . and ./ the same (../ === .., ../../ === ../..)
+  // this is the same behavior as new URL()
+  if (lastToSegment === '..' || lastToSegment === '.') {
+    toSegments.push('')
+  }
 
   let position = fromSegments.length - 1
   let toPosition: number
