fix(query): allow arbitrary keys in queries

posva · posva · commit a57b5f179b88 · 2021-05-27T15:14:24.000+02:00
Revert "fix: do not allow invalid hazardous keys in query (#880)" This reverts commit ecd52e0.
diff --git a/__tests__/parseQuery.spec.ts b/__tests__/parseQuery.spec.ts
@@ -85,15 +85,4 @@ describe('parseQuery', () => {
 
     expect('decoding "%"').toHaveBeenWarnedTimes(1)
   })
-
-  it('ignores __proto__', () => {
-    const query = parseQuery('__proto__=1')
-    expect(query.__proto__).toEqual(Object.prototype)
-    expect(query.constructor).toEqual(Object)
-  })
-
-  it('ignores build-in methods', () => {
-    const query = parseQuery('toString=1')
-    expect(query.toString).toEqual(Object.prototype.toString)
-  })
 })
diff --git a/src/query.ts b/src/query.ts
@@ -57,12 +57,6 @@ export function parseQuery(search: string): LocationQuery {
     // allow the = character
     let eqPos = searchParam.indexOf('=')
     let key = decode(eqPos < 0 ? searchParam : searchParam.slice(0, eqPos))
-
-    // this ignores ?__proto__&toString
-    if (Object.prototype.hasOwnProperty(key)) {
-      continue
-    }
-
     let value = eqPos < 0 ? null : decode(searchParam.slice(eqPos + 1))
 
     if (key in query) {
