perf: use index access for strings

posva · posva · commit 971fea415fcc · 2020-04-22T22:22:05.000+02:00
diff --git a/src/history/common.ts b/src/history/common.ts
@@ -162,7 +162,7 @@ export function normalizeBase(base?: string): string {
   // ensure leading slash when it was removed by the regex above avoid leading
   // slash with hash because the file could be read from the disk like file://
   // and the leading slash would cause problems
-  if (base.charAt(0) !== '/' && base.charAt(0) !== '#') base = '/' + base
+  if (base[0] !== '/' && base[0] !== '#') base = '/' + base
 
   // remove the trailing slash so all other method can just do `base + fullPath`
   // to build an href
diff --git a/src/history/html5.ts b/src/history/html5.ts
@@ -39,7 +39,7 @@ function createCurrentLocation(
   if (hashPos > -1) {
     // prepend the starting slash to hash so the url starts with /#
     let pathFromHash = hash.slice(1)
-    if (pathFromHash.charAt(0) !== '/') pathFromHash = '/' + pathFromHash
+    if (pathFromHash[0] !== '/') pathFromHash = '/' + pathFromHash
     return normalizeHistoryLocation(stripBase(pathFromHash, ''))
   }
   const path = stripBase(pathname, base)
diff --git a/src/utils/location.ts b/src/utils/location.ts
@@ -95,7 +95,8 @@ export function stringifyURL(
  * @param base - base to strip off
  */
 export function stripBase(pathname: string, base: string): string {
-  if (!base || pathname.indexOf(base) !== 0) return pathname
+  // no base or base is not found at the begining
+  if (!base || pathname.indexOf(base)) return pathname
   return pathname.replace(base, '') || '/'
 }
 

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ function createCurrentLocation(`
`39`	`39`	`if (hashPos > -1) {`
`40`	`40`	`// prepend the starting slash to hash so the url starts with /#`
`41`	`41`	`let pathFromHash = hash.slice(1)`
`42`		`- if (pathFromHash.charAt(0) !== '/') pathFromHash = '/' + pathFromHash`
	`42`	`+ if (pathFromHash[0] !== '/') pathFromHash = '/' + pathFromHash`
`43`	`43`	`return normalizeHistoryLocation(stripBase(pathFromHash, ''))`
`44`	`44`	`}`
`45`	`45`	`const path = stripBase(pathname, base)`
Original file line number	Diff line number	Diff line change
`@@ -95,7 +95,8 @@ export function stringifyURL(`
`95`	`95`	`* @param base - base to strip off`
`96`	`96`	`*/`
`97`	`97`	`export function stripBase(pathname: string, base: string): string {`
`98`		`- if (!base \|\| pathname.indexOf(base) !== 0) return pathname`
	`98`	`+ // no base or base is not found at the begining`
	`99`	`+ if (!base \|\| pathname.indexOf(base)) return pathname`
`99`	`100`	`return pathname.replace(base, '') \|\| '/'`
`100`	`101`	`}`
`101`	`102`