feat(warn): improve message for onBeforeRoute*()

posva · posva · commit 7d5230e55600 · 2021-10-01T11:55:58.000+02:00
diff --git a/src/navigationGuards.ts b/src/navigationGuards.ts
@@ -67,7 +67,7 @@ export function onBeforeRouteLeave(leaveGuard: NavigationGuard) {
   if (!activeRecord) {
     __DEV__ &&
       warn(
-        'No active route record was found. Are you missing a <router-view> component?'
+        'No active route record was found when calling `onBeforeRouteLeave()`. Make sure you call this function inside of a component child of <router-view>. Maybe you called it inside of App.vue?'
       )
     return
   }
@@ -99,7 +99,7 @@ export function onBeforeRouteUpdate(updateGuard: NavigationGuard) {
   if (!activeRecord) {
     __DEV__ &&
       warn(
-        'No active route record was found. Are you missing a <router-view> component?'
+        'No active route record was found when calling `onBeforeRouteUpdate()`. Make sure you call this function inside of a component child of <router-view>. Maybe you called it inside of App.vue?'
       )
     return
   }

Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,7 @@ export function onBeforeRouteLeave(leaveGuard: NavigationGuard) {`
`67`	`67`	`if (!activeRecord) {`
`68`	`68`	`__DEV__ &&`
`69`	`69`	`warn(`
`70`		`- 'No active route record was found. Are you missing a <router-view> component?'`
	`70`	+ 'No active route record was found when calling `onBeforeRouteLeave()`. Make sure you call this function inside of a component child of <router-view>. Maybe you called it inside of App.vue?'
`71`	`71`	`)`
`72`	`72`	`return`
`73`	`73`	`}`
`@@ -99,7 +99,7 @@ export function onBeforeRouteUpdate(updateGuard: NavigationGuard) {`
`99`	`99`	`if (!activeRecord) {`
`100`	`100`	`__DEV__ &&`
`101`	`101`	`warn(`
`102`		`- 'No active route record was found. Are you missing a <router-view> component?'`
	`102`	+ 'No active route record was found when calling `onBeforeRouteUpdate()`. Make sure you call this function inside of a component child of <router-view>. Maybe you called it inside of App.vue?'
`103`	`103`	`)`
`104`	`104`	`return`
`105`	`105`	`}`