feat(warn): better wording

posva · posva · commit 4cc3093d0485 · 2022-08-25T13:49:51.000+02:00
#1530
diff --git a/packages/router/__tests__/warnings.spec.ts b/packages/router/__tests__/warnings.spec.ts
@@ -68,7 +68,7 @@ describe('warnings', () => {
       routes: [{ path: '/:p/:c', alias: ['/:p/c'], component }],
     })
     expect(
-      'Alias "/:p/c" and the original record: "/:p/:c" should have the exact same param named "c"'
+      'Alias "/:p/c" and the original record: "/:p/:c" must have the exact same param named "c"'
     ).toHaveBeenWarned()
   })
 
@@ -90,7 +90,7 @@ describe('warnings', () => {
       ],
     })
     expect(
-      `Absolute path "/:a/b" should have the exact same param named "b" as its parent "/:a/:b".`
+      `Absolute path "/:a/b" must have the exact same param named "b" as its parent "/:a/:b".`
     ).toHaveBeenWarned()
   })
 
@@ -100,7 +100,7 @@ describe('warnings', () => {
       routes: [{ path: '/:p/:c', alias: ['/:p/:c+'], component }],
     })
     expect(
-      'Alias "/:p/:c+" and the original record: "/:p/:c" should have the exact same param named "c"'
+      'Alias "/:p/:c+" and the original record: "/:p/:c" must have the exact same param named "c"'
     ).toHaveBeenWarned()
   })
 
@@ -110,7 +110,7 @@ describe('warnings', () => {
       routes: [{ path: '/:p/c', alias: ['/:p/:c'], component }],
     })
     expect(
-      'Alias "/:p/:c" and the original record: "/:p/c" should have the exact same param named "c"'
+      'Alias "/:p/:c" and the original record: "/:p/c" must have the exact same param named "c"'
     ).toHaveBeenWarned()
   })
 
@@ -139,7 +139,7 @@ describe('warnings', () => {
 
   it('warns if a non valid function is passed as a component', async () => {
     const Functional: FunctionalComponent = () => h('div', 'functional')
-    // Functional should have a displayName to avoid the warning
+    // Functional must have a displayName to avoid the warning
 
     const router = createRouter({
       history: createMemoryHistory(),
diff --git a/packages/router/src/matcher/index.ts b/packages/router/src/matcher/index.ts
@@ -449,13 +449,13 @@ function checkSameParams(a: RouteRecordMatcher, b: RouteRecordMatcher) {
   for (const key of a.keys) {
     if (!key.optional && !b.keys.find(isSameParam.bind(null, key)))
       return warn(
-        `Alias "${b.record.path}" and the original record: "${a.record.path}" should have the exact same param named "${key.name}"`
+        `Alias "${b.record.path}" and the original record: "${a.record.path}" must have the exact same param named "${key.name}"`
       )
   }
   for (const key of b.keys) {
     if (!key.optional && !a.keys.find(isSameParam.bind(null, key)))
       return warn(
-        `Alias "${b.record.path}" and the original record: "${a.record.path}" should have the exact same param named "${key.name}"`
+        `Alias "${b.record.path}" and the original record: "${a.record.path}" must have the exact same param named "${key.name}"`
       )
   }
 }
@@ -491,7 +491,7 @@ function checkMissingParamsInAbsolutePath(
   for (const key of parent.keys) {
     if (!record.keys.find(isSameParam.bind(null, key)))
       return warn(
-        `Absolute path "${record.record.path}" should have the exact same param named "${key.name}" as its parent "${parent.record.path}".`
+        `Absolute path "${record.record.path}" must have the exact same param named "${key.name}" as its parent "${parent.record.path}".`
       )
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -449,13 +449,13 @@ function checkSameParams(a: RouteRecordMatcher, b: RouteRecordMatcher) {`
`449`	`449`	`for (const key of a.keys) {`
`450`	`450`	`if (!key.optional && !b.keys.find(isSameParam.bind(null, key)))`
`451`	`451`	`return warn(`
`452`		- `Alias "${b.record.path}" and the original record: "${a.record.path}" should have the exact same param named "${key.name}"`
	`452`	+ `Alias "${b.record.path}" and the original record: "${a.record.path}" must have the exact same param named "${key.name}"`
`453`	`453`	`)`
`454`	`454`	`}`
`455`	`455`	`for (const key of b.keys) {`
`456`	`456`	`if (!key.optional && !a.keys.find(isSameParam.bind(null, key)))`
`457`	`457`	`return warn(`
`458`		- `Alias "${b.record.path}" and the original record: "${a.record.path}" should have the exact same param named "${key.name}"`
	`458`	+ `Alias "${b.record.path}" and the original record: "${a.record.path}" must have the exact same param named "${key.name}"`
`459`	`459`	`)`
`460`	`460`	`}`
`461`	`461`	`}`
`@@ -491,7 +491,7 @@ function checkMissingParamsInAbsolutePath(`
`491`	`491`	`for (const key of parent.keys) {`
`492`	`492`	`if (!record.keys.find(isSameParam.bind(null, key)))`
`493`	`493`	`return warn(`
`494`		- `Absolute path "${record.record.path}" should have the exact same param named "${key.name}" as its parent "${parent.record.path}".`
	`494`	+ `Absolute path "${record.record.path}" must have the exact same param named "${key.name}" as its parent "${parent.record.path}".`
`495`	`495`	`)`
`496`	`496`	`}`
`497`	`497`	`}`