fix(matcher): correct check when removing existing records on add

posva · posva · commit 2c267f5aceec · 2020-05-25T10:17:21.000+02:00
diff --git a/src/matcher/index.ts b/src/matcher/index.ts
@@ -118,6 +118,11 @@ export function createRouterMatcher(
         // otherwise, the first record is the original and others are aliases
         originalMatcher = originalMatcher || matcher
         if (originalMatcher !== matcher) originalMatcher.alias.push(matcher)
+
+        // remove the route if named and only for the top record (avoid in nested calls)
+        // this works because the original record is the first one
+        if (isRootAdd && record.name && !isAliasRecord(matcher))
+          removeRoute(record.name)
       }
 
       // only non redirect records have children
@@ -136,9 +141,6 @@ export function createRouterMatcher(
       // other alias (if any) need to reference this record when adding children
       originalRecord = originalRecord || matcher
 
-      // remove the route if named and only for the top record (avoid in nested calls)
-      if (isRootAdd && record.name) removeRoute(record.name)
-
       insertMatcher(matcher)
     }
 
