fix: resolve relative paths to /

posva · posva · commit 23e25e5b5559 · 2022-06-30T09:59:00.000+02:00
Fix #1410
diff --git a/__tests__/location.spec.ts b/__tests__/location.spec.ts
@@ -329,6 +329,9 @@ describe('resolveRelativePath', () => {
     expect(resolveRelativePath('./../add', '/')).toBe('/add')
     expect(resolveRelativePath('../../add', '/')).toBe('/add')
     expect(resolveRelativePath('../../../add', '/')).toBe('/add')
+    expect(resolveRelativePath('a/add', '/')).toBe('/a/add')
+    expect(resolveRelativePath('./a/add', '/')).toBe('/a/add')
+    expect(resolveRelativePath('../a/add', '/')).toBe('/a/add')
   })
 
   it('ignores it location is absolute', () => {
diff --git a/src/location.ts b/src/location.ts
@@ -215,17 +215,24 @@ export function resolveRelativePath(to: string, from: string): string {
 
   for (toPosition = 0; toPosition < toSegments.length; toPosition++) {
     segment = toSegments[toPosition]
-    // can't go below zero
-    if (position === 1 || segment === '.') continue
-    if (segment === '..') position--
-    // found something that is not relative path
+
+    // we stay on the same position
+    if (segment === '.') continue
+    // go up in the from array
+    if (segment === '..') {
+      // we can't go below zero but we still need to increment toPosition
+      if (position > 1) position--
+      // continue
+    }
+    // we reached a non relative path, we stop here
     else break
   }
 
   return (
     fromSegments.slice(0, position).join('/') +
     '/' +
     toSegments
+      // ensure we use at least the last element in the toSegments
       .slice(toPosition - (toPosition === toSegments.length ? 1 : 0))
       .join('/')
   )
