fix: handle undefined path in router resolve

kedrzu · posva · commit 0ec4862ff542 · 2023-12-15T15:31:15.000+01:00
diff --git a/packages/router/__tests__/router.spec.ts b/packages/router/__tests__/router.spec.ts
@@ -319,6 +319,17 @@ describe('Router', () => {
     await router.push({ name: 'optional', params: {} })
   })
 
+  it('handles undefined path', async () => {
+    const { router } = await newRouter()
+
+    const route1 = router.resolve({
+      path: undefined,
+      params: { p: 'a' },
+    })
+    expect(route1.path).toBe('/')
+    expect(route1.params).toEqual({ p: 'a' })
+  })
+
   it('removes null/undefined optional params when current location has it', async () => {
     const { router } = await newRouter()
 
diff --git a/packages/router/src/matcher/index.ts b/packages/router/src/matcher/index.ts
@@ -290,7 +290,7 @@ export function createRouterMatcher(
       )
       // throws if cannot be stringified
       path = matcher.stringify(params)
-    } else if ('path' in location) {
+    } else if ('path' in location && location.path != null) {
       // no need to resolve the path with the matcher as it was provided
       // this also allows the user to control the encoding
       path = location.path
diff --git a/packages/router/src/router.ts b/packages/router/src/router.ts
@@ -463,7 +463,7 @@ export function createRouter(options: RouterOptions): Router {
     let matcherLocation: MatcherLocationRaw
 
     // path could be relative in object as well
-    if ('path' in rawLocation) {
+    if ('path' in rawLocation && rawLocation.path != null) {
       if (
         __DEV__ &&
         'params' in rawLocation &&

Original file line number	Diff line number	Diff line change
`@@ -290,7 +290,7 @@ export function createRouterMatcher(`
`290`	`290`	`)`
`291`	`291`	`// throws if cannot be stringified`
`292`	`292`	`path = matcher.stringify(params)`
`293`		`- } else if ('path' in location) {`
	`293`	`+ } else if ('path' in location && location.path != null) {`
`294`	`294`	`// no need to resolve the path with the matcher as it was provided`
`295`	`295`	`// this also allows the user to control the encoding`
`296`	`296`	`path = location.path`